Skip to content

Conversation

ghost
Copy link

@ghost ghost commented Jul 13, 2013

It would be nice to have possibility inherit and override 'data' field in state chain (from parent to all children, all way down)

My change adds support for 'data' property inheritance/override in state chain.
Could you please review it ?

@ghost ghost closed this Jul 13, 2013
@ghost ghost reopened this Jul 13, 2013
@ghost
Copy link
Author

ghost commented Jul 13, 2013

added fix for state.self reference

@nateabele
Copy link
Contributor

Could you add a spec test and squash this down to one commit? Thanks.

@ghost
Copy link
Author

ghost commented Jul 13, 2013

Test for 'data' inheritance/override logic was added.

2013/7/13 Nate Abele notifications@github.com

Could you add a spec test and squash this down to one commit? Thanks.


Reply to this email directly or view it on GitHubhttps://github.com//pull/248#issuecomment-20922123
.

best regards,
Baran Alexandr

@nateabele
Copy link
Contributor

The test looks good. If you don't want to squash it, I'll do it myself when I have a chance.

@ghost
Copy link
Author

ghost commented Jul 14, 2013

By 'squash' you mean combine all my commits into one? If so, I'll do it
today evening

2013/7/14 Nate Abele notifications@github.com

The test looks good. If you don't want to squash it, I'll do it myself
when I have a chance.


Reply to this email directly or view it on GitHubhttps://github.com//pull/248#issuecomment-20929863
.

best regards,
Baran Alexandr

@ghost ghost closed this Jul 14, 2013
@nateabele
Copy link
Contributor

Looks good! @ksperling I'm gonna go ahead and merge this because I think it's a pretty straightforward & obvious enhancement. We an roll it back if you disapprove. :-)

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants