Skip to content

Add missing webpack-dev-server devDependency #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2017
Merged

Add missing webpack-dev-server devDependency #157

merged 1 commit into from
Jun 13, 2017

Conversation

jaythomas
Copy link
Contributor

Seems the grunt task depends on webpack-dev-server, because installing it resolved the issue for me.

To replicate the issue:

  1. Clean the repository of any prior installed node_modules and other changes (git clean -xfd)
  2. Make sure webpack and webpack-dev-server node modules aren't globally installed
  3. Run npm install
  4. Run npm run dev

Results: This error will occur...
webpack-dev-server-error

@dhilt dhilt merged commit 478e45b into angular-ui:master Jun 13, 2017
@dhilt
Copy link
Member

dhilt commented Jun 13, 2017

Looks like this is grunt-webpack package issue: https://stackoverflow.com/questions/39364017/grunt-webpack-cannot-find-module-webpack-dev-server. We will add this dependency as a temporary solution, thanks.

@jaythomas
Copy link
Contributor Author

If you update to the latest version of grunt-webpack, it appears it is now made an optional dependency: webpack-contrib/grunt-webpack#70

But since it is required for local development and testing here I think it is best left explicitly defined as a devDependency.

@jaythomas jaythomas deleted the add-webpack-dev-server branch June 13, 2017 17:22
@dhilt
Copy link
Member

dhilt commented Jun 13, 2017

Well, I have updated grunt-webpack and webpack itself, and this has allowed me to remove webpack-dev-server from the project. We are using grunt-contrib-connect for dev server and no webpack-dev-server is needed; the only trouble was in that log-warning. Now the project is clear. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants