Skip to content
This repository has been archived by the owner on Oct 2, 2019. It is now read-only.

Allow sorting of multiple select #651

Merged
merged 2 commits into from
Feb 19, 2015
Merged

Conversation

homerjam
Copy link
Contributor

No description provided.

@wmertens
Copy link

🍻 🎉 👍❗

@dimirc
Copy link
Contributor

dimirc commented Feb 19, 2015

@homerjam LGTM

Only quick issue that found was when dragging all the wat to the right, the index is pasted in the input
image

Btw, why not just sortable as attribute instead of sort-enabled?

@homerjam
Copy link
Contributor Author

I'll try and fix that, I guess we can disable the input while dragging or
something.

I went for sort-enabled because it followed the other options more
closely I thought. I'm not wedded to either though. Anyone else have an
opinion on that? I can easily change my PR, so let me know.
On 19 Feb 2015 02:03, "Wladimir Coka" notifications@github.com wrote:

@homerjam https://github.com/homerjam LGTM

Only quick issue that found was when dragging all the wat to the right,
the index is pasted in the input
[image: image]
https://cloud.githubusercontent.com/assets/5034942/6260739/3bebb8c6-b7b1-11e4-8142-a85829cc7d36.png

Btw, why not just sortable as attribute instead of sort-enabled?


Reply to this email directly or view it on GitHub
#651 (comment).

@homerjam
Copy link
Contributor Author

@dimirc I've resolved that problem you noted - I've also changed the attribute to sortable(think it does make more sense actually)

@dimirc dimirc added this to the 0.10.x milestone Feb 19, 2015
dimirc added a commit that referenced this pull request Feb 19, 2015
Allow sorting of multiple select
@dimirc dimirc merged commit c81e9f4 into angular-ui:master Feb 19, 2015
@dimirc
Copy link
Contributor

dimirc commented Feb 19, 2015

Thanks @homerjam

@stevematyas
Copy link

Can anyone advise at to the proper use of sortable="true"? Reference: #974
cc: @homerjam , @dimirc

@cheesecase
Copy link

Hi, is there a documentation how to use the sorting (sortable="true") for multiple select?

More specifically, is there an option to change the sorting from horizontal to vertical without changing the code?

Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants