angular1.2 minification

[daveedgarcia]

I am currently using the angular1.2 version of ui-sortable and I received errors once we minified our JS.

We received the following errors from inside sortable.js:

1. ReferenceError: onStop is not defined
2. cannot call methods on sortable prior to initialization; attempted to call method 'refresh'

Have you seen any issues when others have tried to minify angular.js? Can you think of any reason why minifiying might effect the code this way?

Thanks

[thgreasi]

Interesting...

• In most of the cases that the second message appears, the script include order is to blame. In sort, it might be that jquery is not loaded before angularjs.
• onStop as a keyword does not exist in the current codebase!?!? Reference errors tend to occur in case that ngModel is not defined in uiSortable directives (I`m not telling that this has to be the case).

Hope I could be more helpful...
Can you bring an example? Ideally 2 pens/fiddles/etc of the demo code, one before and one after your preferred minification method.

[daveedgarcia]

Just realized we are using angular-ui-sortable 0.0.1 with angular 1.2.4 in our bower.json
Is there a certain version we should be using?

[thgreasi]

Just merged angular1.2 branch into the master branch.
This now is mainly focused to angularjs 1.2.x+.
I suggest you to use v0.12.x (for angularjs 1.2 support) bower package (also just got created).

Feel free to reopen if necessary.

[harshil07]

I'm getting a different error but similar issue. using angular 1.2.28 with ui-sortable 0.12.11

TypeError: undefined is not a function
    at t.module.value.directive.link (http://localhost:8000/static/app/js/bootstrap.build.js?rel=1425508526373:380:748633)
    at http://localhost:8000/static/app/js/bootstrap.build.js?rel=1425508526373:380:124984
    at y (http://localhost:8000/static/app/js/bootstrap.build.js?rel=1425508526373:380:120018)
    at u (http://localhost:8000/static/app/js/bootstrap.build.js?rel=1425508526373:380:116390)
    at u (http://localhost:8000/static/app/js/bootstrap.build.js?rel=1425508526373:380:116407)
    at http://localhost:8000/static/app/js/bootstrap.build.js?rel=1425508526373:380:116017
    at $get.s (http://localhost:8000/static/app/js/bootstrap.build.js?rel=1425508526373:380:116859)
    at p (http://localhost:8000/static/app/js/bootstrap.build.js?rel=1425508526373:380:118679)
    at http://localhost:8000/static/app/js/bootstrap.build.js?rel=1425508526373:380:195180
    at Object.fn (http://localhost:8000/static/app/js/bootstrap.build.js?rel=1425508526373:380:147703) <div class="list-content ng-isolate-scope ng-pristine ng-valid" style="min-height: 10px" ui-sortable="applicationSortableOptions" ng-model="state.applications">

[harshil07]

realized issue was JQueryUI also needs to be included before angularjs not just JQuery.
updated readme here. #342