fix(sortable): fix connected lists with helper for last spot drops #187
Conversation
When using sortable between two lists and a helper function (not 'clone') there is a problem if you drop an item at the last spot. The first time it works, the second time it will add it as the first element of the list. It continues this way for every even drop as the last item. You can check it here: http://codepen.io/anon/pen/FyaJs See issue here: angular-ui#186
|
Thanks for the great job! |
|
I currently face problems while trying to create a test case for this to be merged. Simulating a drag to the end of a list seems "hard". |
|
No way that it will be committed without a test? On Tue, Jun 3, 2014 at 7:16 PM, Thodoris Greasidis <notifications@github.com
|
|
Since I have spent over 3 hours without any progress on cross-list last-place sorting, I might merge it during the weekend (that nobody is around). |
thgreasi
changed the title
thgreasi
changed the title
fix(sortable): fix connected lists with helper for last spot drops
|
I justed merged this PR and opened #197 to track the lack of tests. |
When using sortable between two lists and a helper function (not 'clone') there is a problem if you drop an item at the last spot.
The first time it works, the second time it will add it as the first element of the list.
It continues this way for every even drop as the last item.
You can check it here:
http://codepen.io/anon/pen/FyaJs
Closes #186