Skip to content
This repository was archived by the owner on Sep 8, 2020. It is now read-only.

Conversation

fishfacemcgee
Copy link
Contributor

A different incarnation of this was introduced in #293.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 7112924 on fishfacemcgee:proper-attr-read into aedb58f on angular-ui:master.

@thgreasi
Copy link
Contributor

Great 👍
We should rebase it into one or two semantic commits I think.
I will do it during the merge, if you don't have the time.

@fishfacemcgee
Copy link
Contributor Author

I'm not really familiar with doing rebases. If you want, I can give it a shot later today and let you know if something went horribly wrong. 😄

@thgreasi
Copy link
Contributor

On then, if it's easier for you, close this PR and open a new one with just the data-ng-model fix.

@thgreasi
Copy link
Contributor

I should have been more specific...
Just open a new PR with one combined commit (or two if you prefer to keep the whitespace commit separate).
If we can write some tests, we can push them in a separate commit.

@fishfacemcgee
Copy link
Contributor Author

I think I understand now. Closing this as #295 should have what you're looking for now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants