This repository was archived by the owner on Sep 8, 2020. It is now read-only.
feat(sortable): use $watchCollection instead of $watch #333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can this be merged? |
|
Can you undo .gitignore, I do you think that it is required by this repo? |
undid demo.js changes. added unit test that uses document.body as the appendTo removed gitignore changes
|
I guess not. Updated .gitignore and squashed commits |
thgreasi
added a commit
that referenced
this pull request
Feb 9, 2015
fix(sortable): fix non-string appendTo SortableOption using $watchCollection
|
Thanks for your effort 👍 |
thgreasi
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #330