Skip to content
This repository was archived by the owner on Sep 8, 2020. It is now read-only.

Compatibility with angular-utils-pagination #499

Closed
wants to merge 1 commit into from

Conversation

rafalboguski
Copy link

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 616e658 on rafalboguski:master into 90d2672 on angular-ui:master.

Copy link
Contributor

@thgreasi thgreasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there and thanks for the contribution!
I thought that we don't support ng-repeat-star/end!
Can you provide a sample codepen (preferably by forking one of those in README) so that I can update the test cases to not fail on this PR?

@thgreasi
Copy link
Contributor

thgreasi commented Mar 6, 2017

Hi there. Just checking back on this after some time.

Can you provide a sample codepen (preferably by forking one of those in README) so that I can update the test cases to not fail on this PR?

@thgreasi
Copy link
Contributor

thgreasi commented Mar 8, 2017

After forking and giving a try on the project's demo it seems that ui-sortable can work without the ng-repeat-start change (even though I didn't complete the implementation to work for the rest pages). If you can't replace the ng-repeat-start with a simple ng-repeat, you can use the items option like this "items": "> * ng-repeat-start", like in the angular material integration example.

@thgreasi thgreasi closed this Mar 8, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants