This repository was archived by the owner on Jan 24, 2019. It is now read-only.
Keypress Module: Take keyCode normalization into account when checking key combinations #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh... I see ... this fix will be of no use, if the module is changed for the suggestions in pull request #6 |
ProLoser
added a commit
that referenced
this pull request
Jun 21, 2013
Keypress Module: Take keyCode normalization into account when checking key combinations
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't encountered any problems and actuelly I don't know about the fact that keypress keycodes should be normalized. Anyway the normalized code should be used in the loop instead of the original keycode from the event object to have an effect.