fix(@angular-devkit/build-webpack): avoid deprecation warning with We…

…bpack 5 watch mode With Webpack 5, passing the watch configuration option into the `webpack` factory function will cause the Webpack compiler to assume it should immediately start watching which requires a callback to be passed as well. Since the execution of the compiler is handled later in the process, a callback at the compiler creation stage is undesirable and could result in potentially breaking changes to accomplish.
angular · Sep 30, 2020 · 1c61ced · 1c61ced
1 parent dcad2ee
commit 1c61ced
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/packages/angular_devkit/build_webpack/src/webpack-dev-server/index.ts b/packages/angular_devkit/build_webpack/src/webpack-dev-server/index.ts
@@ -68,7 +68,7 @@ export function runWebpackDevServer(
   // Disable stats reporting by the devserver, we have our own logger.
   devServerConfig.stats = false;
 
-  return createWebpack(config).pipe(
+  return createWebpack({ ...config, watch: false }).pipe(
     switchMap(webpackCompiler => new Observable<DevServerBuildOutput>(obs => {
       const server = createWebpackDevServer(webpackCompiler, devServerConfig);
       let result: DevServerBuildOutput;

diff --git a/packages/angular_devkit/build_webpack/src/webpack/index.ts b/packages/angular_devkit/build_webpack/src/webpack/index.ts
@@ -50,7 +50,7 @@ export function runWebpack(
   const log: WebpackLoggingCallback = options.logging
     || ((stats, config) => context.logger.info(stats.toString(config.stats)));
 
-  return createWebpack(config).pipe(
+  return createWebpack({ ...config, watch: false }).pipe(
     switchMap(webpackCompiler => new Observable<BuildResult>(obs => {
       const callback = (err?: Error, stats?: webpack.Stats) => {
         if (err) {