Skip to content

Commit dc7a4d8

Browse files
clydinfilipesilva
authored andcommitted
feat(@angular/cli): shorten output filenames
1 parent 0393429 commit dc7a4d8

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

45 files changed

+236
-234
lines changed

docs/documentation/stories/universal-rendering.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ import {AppComponent} from './app.component';
7272
// The AppServerModule should import your AppModule followed
7373
// by the ServerModule from @angular/platform-server.
7474
AppModule,
75-
ServerModule,
75+
ServerModule,
7676
ModuleMapLoaderModule // <-- *Important* to have lazy-loaded routes work
7777
],
7878
// Since the bootstrapped component is not inherited from your
@@ -191,8 +191,8 @@ $ ng build --prod --app 1 --output-hashing=false
191191
Date: 2017-07-24T22:42:09.739Z
192192
Hash: 9cac7d8e9434007fd8da
193193
Time: 4933ms
194-
chunk {0} main.bundle.js (main) 9.49 kB [entry] [rendered]
195-
chunk {1} styles.bundle.css (styles) 0 bytes [entry] [rendered]
194+
chunk {0} main.js (main) 9.49 kB [entry] [rendered]
195+
chunk {1} styles.css (styles) 0 bytes [entry] [rendered]
196196
```
197197

198198
---

packages/@angular/cli/models/webpack-configs/browser.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ export function getBrowserConfig(wco: WebpackConfigOptions) {
8282
crossOriginLoading: buildOptions.subresourceIntegrity ? 'anonymous' : false
8383
},
8484
optimization: {
85-
// runtimeChunk: 'single',
85+
runtimeChunk: 'single',
8686
splitChunks: {
8787
chunks: buildOptions.commonChunk ? 'all' : 'initial',
8888
cacheGroups: {

packages/@angular/cli/models/webpack-configs/common.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ export function getCommonConfig(wco: WebpackConfigOptions) {
7070
extraPlugins.push(new ScriptsWebpackPlugin({
7171
name: script.entry,
7272
sourceMap: buildOptions.sourcemaps,
73-
filename: `${script.entry}${hash}.bundle.js`,
73+
filename: `${script.entry}${hash}.js`,
7474
scripts: script.paths,
7575
basePath: projectRoot,
7676
}));
@@ -215,8 +215,7 @@ export function getCommonConfig(wco: WebpackConfigOptions) {
215215
output: {
216216
path: path.resolve(buildOptions.outputPath),
217217
publicPath: buildOptions.deployUrl,
218-
filename: `[name]${hashFormat.chunk}.bundle.js`,
219-
chunkFilename: `[id]${hashFormat.chunk}.chunk.js`
218+
filename: `[name]${hashFormat.chunk}.js`,
220219
},
221220
module: {
222221
rules: [

packages/@angular/cli/models/webpack-configs/styles.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -265,12 +265,14 @@ export function getStylesConfig(wco: WebpackConfigOptions) {
265265
if (buildOptions.extractCss) {
266266
// extract global css from js files into own css file
267267
extraPlugins.push(
268-
new ExtractTextPlugin({ filename: `[name]${hashFormat.extract}.bundle.css` }));
268+
new ExtractTextPlugin({ filename: `[name]${hashFormat.extract}.css` }));
269269
// suppress empty .js files in css only entry points
270270
extraPlugins.push(new SuppressExtractedTextChunksWebpackPlugin());
271271
}
272272

273273
return {
274+
// Workaround stylus-loader defect: https://github.com/shama/stylus-loader/issues/189
275+
loader: { stylus: {} },
274276
entry: entryPoints,
275277
module: { rules },
276278
plugins: [].concat(extraPlugins)

packages/@angular/cli/plugins/karma-context.html

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -26,13 +26,13 @@
2626
// All served files with the latest timestamps
2727
%MAPPINGS%
2828
</script>
29-
<script type="text/javascript" src="_karma_webpack_/inline.bundle.js" crossorigin="anonymous"></script>
30-
<script type="text/javascript" src="_karma_webpack_/polyfills.bundle.js" crossorigin="anonymous"></script>
29+
<script type="text/javascript" src="_karma_webpack_/runtime.js" crossorigin="anonymous"></script>
30+
<script type="text/javascript" src="_karma_webpack_/polyfills.js" crossorigin="anonymous"></script>
3131
<!-- Dynamically replaced with <script> tags -->
3232
%SCRIPTS%
33-
<script type="text/javascript" src="_karma_webpack_/scripts.bundle.js" crossorigin="anonymous"></script>
34-
<script type="text/javascript" src="_karma_webpack_/vendor.bundle.js" crossorigin="anonymous"></script>
35-
<script type="text/javascript" src="_karma_webpack_/main.bundle.js" crossorigin="anonymous"></script>
33+
<script type="text/javascript" src="_karma_webpack_/scripts.js" crossorigin="anonymous"></script>
34+
<script type="text/javascript" src="_karma_webpack_/vendor.js" crossorigin="anonymous"></script>
35+
<script type="text/javascript" src="_karma_webpack_/main.js" crossorigin="anonymous"></script>
3636
<script type="text/javascript">
3737
window.__karma__.loaded();
3838
</script>

packages/@angular/cli/plugins/karma-debug.html

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,13 +28,13 @@
2828
// All served files with the latest timestamps
2929
%MAPPINGS%
3030
</script>
31-
<script type="text/javascript" src="_karma_webpack_/inline.bundle.js" crossorigin="anonymous"></script>
32-
<script type="text/javascript" src="_karma_webpack_/polyfills.bundle.js" crossorigin="anonymous"></script>
31+
<script type="text/javascript" src="_karma_webpack_/runtime.js" crossorigin="anonymous"></script>
32+
<script type="text/javascript" src="_karma_webpack_/polyfills.js" crossorigin="anonymous"></script>
3333
<!-- Dynamically replaced with <script> tags -->
3434
%SCRIPTS%
35-
<script type="text/javascript" src="_karma_webpack_/scripts.bundle.js" crossorigin="anonymous"></script>
36-
<script type="text/javascript" src="_karma_webpack_/vendor.bundle.js" crossorigin="anonymous"></script>
37-
<script type="text/javascript" src="_karma_webpack_/main.bundle.js" crossorigin="anonymous"></script>
35+
<script type="text/javascript" src="_karma_webpack_/scripts.js" crossorigin="anonymous"></script>
36+
<script type="text/javascript" src="_karma_webpack_/vendor.js" crossorigin="anonymous"></script>
37+
<script type="text/javascript" src="_karma_webpack_/main.js" crossorigin="anonymous"></script>
3838
<script type="text/javascript">
3939
window.__karma__.loaded();
4040
</script>

packages/@angular/cli/plugins/karma.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -207,10 +207,10 @@ const init: any = (config: any, emitter: any, customFileHandlers: any) => {
207207
// Ensure script and style bundles are served.
208208
// They are mentioned in the custom karma context page and we don't want them to 404.
209209
const alwaysServe = [
210-
'/_karma_webpack_/inline.bundle.js',
211-
'/_karma_webpack_/polyfills.bundle.js',
212-
'/_karma_webpack_/scripts.bundle.js',
213-
'/_karma_webpack_/vendor.bundle.js',
210+
'/_karma_webpack_/runtime.js',
211+
'/_karma_webpack_/polyfills.js',
212+
'/_karma_webpack_/scripts.js',
213+
'/_karma_webpack_/vendor.js',
214214
];
215215
if (alwaysServe.indexOf(req.url) != -1) {
216216
res.statusCode = 200;

packages/@angular/cli/tasks/render-universal.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ export default Task.extend({
2121
// Get the main bundle from the server build's output directory.
2222
const serverDir = fs.readdirSync(options.serverOutDir);
2323
const serverMainBundle = serverDir
24-
.filter((file: string) => /main\.(?:[a-zA-Z0-9]{20}\.)?bundle\.js/.test(file))[0];
24+
.filter((file: string) => /main\.(?:[a-zA-Z0-9]{20}\.)?js/.test(file))[0];
2525
const serverBundlePath = join(options.serverOutDir, serverMainBundle);
2626
const AppServerModuleNgFactory = require(serverBundlePath).AppServerModuleNgFactory;
2727

packages/@ngtools/webpack/src/angular_compiler_plugin.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -589,7 +589,7 @@ export class AngularCompilerPlugin {
589589
const modulePath = this._lazyRoutes[key];
590590
const importPath = key.split('#')[0];
591591
if (modulePath !== null) {
592-
const name = path.basename(importPath).replace(/(\.ngfactory)?\.(js|ts)$/, '');
592+
const name = importPath.replace(/(\.ngfactory)?\.(js|ts)$/, '');
593593
return new ContextElementDependency(modulePath, name);
594594
} else {
595595
return null;

tests/e2e/tests/basic/aot.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,6 @@ import {expectFileToMatch} from '../../utils/fs';
33

44
export default function() {
55
return ng('build', '--aot')
6-
.then(() => expectFileToMatch('dist/main.bundle.js',
6+
.then(() => expectFileToMatch('dist/main.js',
77
/platformBrowser.*bootstrapModuleFactory.*AppModuleNgFactory/));
88
}

0 commit comments

Comments
 (0)