-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent numbers in module/pipe names #12868
Labels
2022Q3 Fixit
Candidates for the Q3 2022 fix-it
area: @schematics/angular
freq1: low
Only reported by a handful of users who observe it rarely
severity2: inconvenient
type: bug/fix
workaround1: obvious
Milestone
Comments
alan-agius4
added
freq1: low
Only reported by a handful of users who observe it rarely
severity2: inconvenient
area: @schematics/angular
labels
Nov 6, 2018
alan-agius4
added a commit
to alan-agius4/angular-cli
that referenced
this issue
Jul 1, 2022
With this change we prevent creating classes with invalid characters. Closes angular#12868
alan-agius4
added a commit
to alan-agius4/angular-cli
that referenced
this issue
Jul 1, 2022
With this change we prevent creating classes with invalid characters. Closes angular#12868
alan-agius4
added a commit
to alan-agius4/angular-cli
that referenced
this issue
Jul 1, 2022
With this change we prevent creating classes with invalid characters. Closes angular#12868
alan-agius4
added a commit
to alan-agius4/angular-cli
that referenced
this issue
Jul 1, 2022
…parallel to `RoutingModule` Prior to this commit, we defined routes in two places example: ```ts @NgModule({ declarations: [ HomeComponent ], imports: [ CommonModule, RouterModule.forChild(routes), HomeRoutingModule ] }) export class HomeModule { } ``` Closes angular#12868
alan-agius4
added a commit
to alan-agius4/angular-cli
that referenced
this issue
Jul 1, 2022
…o `RoutingModule` Prior to this commit, we defined routes in two places example: ```ts @NgModule({ declarations: [ HomeComponent ], imports: [ CommonModule, RouterModule.forChild(routes), HomeRoutingModule ] }) export class HomeModule { } ``` Closes angular#12868
alan-agius4
added a commit
to alan-agius4/angular-cli
that referenced
this issue
Jul 3, 2022
With this change we prevent creating classes with invalid characters. Closes angular#12868
alan-agius4
added a commit
to alan-agius4/angular-cli
that referenced
this issue
Jul 21, 2022
With this change we prevent creating classes with invalid characters. Closes angular#12868
clydin
pushed a commit
that referenced
this issue
Jul 21, 2022
With this change we prevent creating classes with invalid characters. Closes #12868
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
2022Q3 Fixit
Candidates for the Q3 2022 fix-it
area: @schematics/angular
freq1: low
Only reported by a handful of users who observe it rarely
severity2: inconvenient
type: bug/fix
workaround1: obvious
Bug Report or Feature Request (mark with an
x
)Command (mark with an
x
)Versions
Angular CLI: 6.2.1
Node: 8.11.2
OS: darwin x64
Angular: 6.1.7
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, platform-server, router
Package Version
@angular-devkit/architect 0.8.1
@angular-devkit/build-angular 0.8.1
@angular-devkit/build-webpack 0.8.1
@angular-devkit/core 0.8.1
@angular-devkit/schematics 0.8.1
@angular/cdk 6.4.7
@angular/cli 6.2.1
@angular/material 6.4.7
@schematics/angular 0.8.1
@schematics/update 0.8.1
rxjs 6.3.2
typescript 2.9.2
webpack 4.19.0
Repro steps
The log given by the failure
Everything performs smoothly. The pipe is created, but referencing modules with numbers in name creates problems, like here, referencing names with numbers.
Desired functionality
The cli should disallow names with numbers to prevent issues.
The text was updated successfully, but these errors were encountered: