wip! webpack 5 #16371
Closed
wip! webpack 5 #16371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clydin
reviewed
Dec 6, 2019
| @@ -93,15 +93,9 @@ export function getBrowserConfig(wco: WebpackConfigOptions): webpack.Configurati | |||
| vendors: false, | |||
| vendor: !!buildOptions.vendorChunk && { | |||
| name: 'vendor', | |||
| chunks: 'initial', | |||
There was a problem hiding this comment.
Is initial chunks automatic now? Only node module files from initial chunks should end up in the vendor chunk. Otherwise the main bundle in production mode will contain all dependencies for the entire application including ones only used in lazy routes.
alan-agius4
commented
Dec 6, 2019
| @@ -13,6 +13,6 @@ | |||
| "source-map": "0.7.3", | |||
| "tslib": "1.10.0", | |||
| "typescript": "3.6.4", | |||
| "webpack-sources": "1.4.3" | |||
| "webpack-sources": "2.0.0-beta.8" | |||
There was a problem hiding this comment.
Updating this seems to cause a bunch of tsc errors due to tapable
|
Closing since these were POC’s |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.