[9.1.x] test: move app-shell tests to flake jail #18252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
App-shell builder imports zone.js, which patches the global promises. In some cases this will causes flakiness in tests that run after this one. With this change we move the app-shell tests to the flake jail and force them to be run at the very last. Successful runs when disabling app-shell tests from test-large https://circleci.com/workflow-run/4afb40f2-19ec-46ab-bb94-4153d448e6ad (cherry picked from commit 7cb470f)
alan-agius4
added
target: lts
alan-agius4
changed the title
clydin
approved these changes
Jul 15, 2020
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
App-shell builder imports zone.js, which patches the global promises. In some cases this will causes flakiness in tests that run after this one.
With this change we move the app-shell tests to the flake jail and force them to be run at the very last.
Successful runs when disabling app-shell tests from test-large
https://circleci.com/workflow-run/4afb40f2-19ec-46ab-bb94-4153d448e6ad
(cherry picked from commit 7cb470f)