Skip to content

Conversation

clydin
Copy link
Member

@clydin clydin commented Aug 17, 2020

This change adds support for extracting i18n translation messages with an Ivy enabled application. This is accomplished by using the new extraction capabilities present in the @angular/localize package and will require version 10.1 or later of the package. Since this change uses an new extraction method, it currently must be enabled during extraction by using the --ivy flag. The flag is a precaution to prevent unintentional breakage for existing applications but will become the default behavior for all Ivy enabled applications in a future release.

Closes #18275

@clydin clydin added target: major This PR is targeted for the next major release state: blocked labels Aug 17, 2020
@clydin clydin force-pushed the ivy-extract branch 3 times, most recently from 2a2b429 to a240638 Compare August 17, 2020 21:13
@clydin clydin marked this pull request as ready for review August 17, 2020 21:39
@clydin clydin requested a review from alan-agius4 August 17, 2020 21:43
clydin added 2 commits August 18, 2020 10:17
…with Ivy

This change adds support for extracting i18n translation messages with an Ivy enabled application. This is accomplished by using the new extraction capabilities present in the `@angular/localize` package and will require version 10.1 or later of the package.  Since this change uses an new extraction method, it currently must be enabled during extraction by using the `--ivy` flag. The flag is a precaution to prevent unintentional breakage for existing applications but will become the default behavior for all Ivy enabled applications in a future release.

Closes angular#18275
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Aug 18, 2020
@alan-agius4 alan-agius4 merged commit d096e57 into angular:master Aug 18, 2020
@clydin clydin deleted the ivy-extract branch August 18, 2020 14:50
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

i18n - implement new ivy translation message extractor
3 participants