Skip to content

fix(@schematics/angular): fix youtube icon margin #20274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 15, 2021
Merged

fix(@schematics/angular): fix youtube icon margin #20274

merged 1 commit into from
Mar 15, 2021

Conversation

OmarioHassan
Copy link
Contributor

change youtube icon style from margin-left: 16px; to margin: 0 16px;

to be like this
image

instead of this
image

@google-cla google-cla bot added the cla: yes label Mar 15, 2021
@OmarioHassan OmarioHassan changed the title fix(starter application): fix style for youtube fix(@angular/cli): fix style for youtube Mar 15, 2021
alan-agius4
alan-agius4 requested changes Mar 15, 2021
View reviewed changes
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.

Can you please fix the commit message to

fix(@schematics/angular): fix youtube icon margin

Thanks.

@alan-agius4 alan-agius4 added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Mar 15, 2021
@OmarioHassan OmarioHassan changed the title fix(@angular/cli): fix style for youtube fix(@schematics/angular): fix youtube icon margin Mar 15, 2021
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Mar 15, 2021
alan-agius4
alan-agius4 approved these changes Mar 15, 2021
View reviewed changes
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@alan-agius4 alan-agius4 merged commit 9ea34ba into angular:master Mar 15, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alan-agius4 alan-agius4 alan-agius4 approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OmarioHassan @alan-agius4