perf(@angular-devkit/build-angular): disable showCircularDependencies by default
#20278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
target: major
…s` by default Change the default of this flag to disabled by default as this is a caused of rebuild performance degradation for large projects. BREAKING CHANGE The server and browser builder `showCircularDependencies` option default value has been changed from `true` to `false`.
JoostK
reviewed
Mar 16, 2021
clydin
reviewed
Mar 16, 2021
clydin
reviewed
Mar 16, 2021
...es/angular_devkit/build_angular/src/browser/tests/options/show-circular-dependencies_spec.ts
Outdated
Show resolved
Hide resolved
…` tests to use new test harness
clydin
approved these changes
Mar 16, 2021
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the default of this flag to disabled by default as this is a caused of rebuild performance degradation for large projects.
BREAKING CHANGE
The server and browser builder
showCircularDependenciesoption default value has been changed fromtruetofalse.