Skip to content

Conversation

clydin
Copy link
Member

@clydin clydin commented Apr 6, 2021

See individual commits.

clydin added 2 commits April 6, 2021 10:15
…mr and liveReload option tests

The CommonJS usage warning tests are moved to use the builder harness for both the `hmr` and `liveReload` options.
…on tests

This change adds expanded unit tests for the dev-server builder's `port` option using the builder test harness.
@clydin clydin added the target: major This PR is targeted for the next major release label Apr 6, 2021
@google-cla google-cla bot added the cla: yes label Apr 6, 2021
… tests

This change updates the remainder of the non-builder harness tests to use a random port when testing. This change reduces the frequency of test flakes as well as improves the opportunity for parallel test execution.
@clydin clydin force-pushed the test-harness/dev-server/four branch from 3f42f09 to 21819b4 Compare April 6, 2021 15:03
@clydin clydin requested a review from alan-agius4 April 6, 2021 15:24
@alan-agius4 alan-agius4 merged commit a6d886d into angular:master Apr 7, 2021
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Apr 7, 2021
@clydin clydin deleted the test-harness/dev-server/four branch April 7, 2021 09:51
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants