fix(@angular-devkit/build-angular): update locale setting snippet to use globalThis.
#24404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…use `globalThis`. This commit changes how we set the `LOCALE_ID` when using the `localize` option - We now include the locale setting snippet only in the main bundle. - We use `globalThis` to set the the value globally and be accessible across module boundaries. This is important as in some causes such as when using MF `@angular/core` can be located in a bundles others than `main` and `vendor`.
alan-agius4
force-pushed
the
inlining-locale
branch
from
2a82eb3 to
9f43fb4
Compare
alan-agius4
added
action: review
clydin
approved these changes
Dec 9, 2022
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes how we set the
LOCALE_IDwhen using thelocalizeoptionglobalThisto set the the value globally and be accessible across module boundaries. This is important as in some causes such as when using MF@angular/corecan be located in a bundles others thanmainandvendor.FYI: @Coly010