Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(@angular-devkit/build-angular): use single JS transformer instance during dev-server prebundling #25801

Merged

Conversation

clydin
Copy link
Member

@clydin clydin commented Sep 7, 2023

By setting up a single instance of the JavaTransformer, the Vite-based development server will now have a fixed and controllable number of worker threads available to process prebundling requests. This avoids a potentially large number of initial worker threads when a new application with a large number of dependencies is first used with the development server. This is particularly beneficial for web container setups which may not be able to efficiently handle the number of workers.

@clydin clydin added the target: major This PR is targeted for the next major release label Sep 7, 2023
…ce during dev-server prebundling

By setting up a single instance of the `JavaTransformer`, the Vite-based development server will now
have a fixed and controllable number of worker threads available to process prebundling requests. This
avoids a potentially large number of initial worker threads when a new application with a large number
of dependencies is first used with the development server. This is particularly beneficial for web
container setups which may not be able to efficiently handle the number of workers.
@clydin clydin force-pushed the dev-server/prebundling-transformer-single branch from 8b6adf5 to 5cd3634 Compare September 7, 2023 15:51
@clydin clydin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Sep 7, 2023
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 8, 2023
@dgp1130 dgp1130 merged commit 4b67d2a into angular:main Sep 8, 2023
35 checks passed
@clydin clydin deleted the dev-server/prebundling-transformer-single branch September 8, 2023 17:20
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants