Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update package output to use ES2022 #25804

Merged
merged 1 commit into from Sep 8, 2023
Merged

Conversation

clydin
Copy link
Member

@clydin clydin commented Sep 7, 2023

The JavaScript generated for the published packages is now using ES2022. This removes additional downleveling of code that was previously necessary to use newer features.
The minimum Node.js version of 18.13 provides support for the needed features. While this change does require a patch to @bazel/concatjs to allow the target to be set to ES2022, this patch is now already required by the migration of the universal repository into the CLI repository.

@clydin clydin added the target: major This PR is targeted for the next major release label Sep 7, 2023
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Sep 7, 2023
The JavaScript generated for the published packages is now using ES2022.
This removes additional downleveling of code that was previously necessary
to use newer features.
The minimum Node.js version of 18.13 provides support for the needed features.
While this change does require a patch to `@bazel/concatjs` to allow the target
to be set to `ES2022`, this patch is now already required by the migration of
the universal repository into the CLI repository.
@clydin clydin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Sep 7, 2023
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 7, 2023
@dgp1130 dgp1130 merged commit 0811f64 into angular:main Sep 8, 2023
35 checks passed
@clydin clydin deleted the build/es2022 branch September 8, 2023 17:20
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants