test: enable build E2E tests for esbuild-based builders #25942
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clydin
force-pushed
the
esbuild/even-more-e2e-tests
branch
7 times, most recently
from
27e582a to
7a0d6b7
Compare
clydin
force-pushed
the
esbuild/even-more-e2e-tests
branch
5 times, most recently
from
3cce286 to
14808ef
Compare
…global scripts in application builder When using the `scripts` option with the esbuild-based builders (`application`/`browser-esbuild`), the JavaScript code from the scripts will now be processed based on the targets provided in the application's browserslist file. This prevents unsupported syntax from being present in the output script chunk that is generated.
clydin
force-pushed
the
esbuild/even-more-e2e-tests
branch
from
14808ef to
dd60a2c
Compare
…perty in Vite-based dev server The protractor E2E builder relies on a development server `baseUrl` result property to determine the address to connect when testing the application. The Vite-based development server now also provides this property. While the protractor builder is considered deprecated, it is still used in CLI E2E tests.
clydin
force-pushed
the
esbuild/even-more-e2e-tests
branch
from
dd60a2c to
547f242
Compare
clydin
added
target: rc
…d correctly with dev server The `server-utils` SSR generated chunk was not previously included in the ESM in memory loader for prerendering which resulted in the ESM resolver incorrectly attempting to resolve non-relative dependencies. This would lead to resolution errors when using the development server with caching enabled. In this scenario, the Angular dependencies would be marked external and the server utilities output chunk would contain non-relative imports and fail to prerender.
clydin
force-pushed
the
esbuild/even-more-e2e-tests
branch
from
547f242 to
f978268
Compare
The build E2E tests have now been enabled for the esbuild-based builders. The bundle budget test is currently skipped pending feature implementation. Several redundant tests were also deleted due to the functionality already being covered by unit tests for the builders.
clydin
force-pushed
the
esbuild/even-more-e2e-tests
branch
from
f978268 to
8b5c48e
Compare
clydin
added
the
action: review
alan-agius4
approved these changes
Nov 1, 2023
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build E2E tests have now been enabled for the esbuild-based builders. The bundle budget test is currently skipped pending feature implementation. Several redundant tests were also deleted due to the functionality already being covered by unit tests for the builders.
Also contains several commits with builder fixes based on the enabled tests.