fix(@schematics/angular): enable TypeScript esModuleInterop by default for ESM compliance
#26146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clydin
force-pushed
the
esbuild/update-tsconfig-defaults
branch
from
c398a7d to
ec454d4
Compare
clydin
changed the title
esModuleInterop by default for ESM complianceesModuleInterop by default for ESM compliance
clydin
added
the
action: review
…ult for ESM compliance The `esModuleInterop` TypeScript option is a TypeScript recommended option that ensures that TypeScript emits compliant ESM code when transforming namespace and default imports. This is important for new projects because they now use the `application` builder which emits full ESM code. Not using this option with certain third-party packages (e.g., `moment`) can result in build warnings and the potential for runtime failure. For existing applications that are considering migrating, information pertaining to this situation will be available within the documentation. Since the `allowSyntheticDefaultImports` is implied and automatically enabled when `esModuleInterop` is enabled, the previous option has been replaced with this one. Reference: https://www.typescriptlang.org/tsconfig#esModuleInterop
clydin
force-pushed
the
esbuild/update-tsconfig-defaults
branch
from
ec454d4 to
2c5503d
Compare
alan-agius4
approved these changes
Oct 26, 2023
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
esModuleInteropTypeScript option is a TypeScript recommended option that ensures that TypeScript emits compliant ESM code when transforming namespace and default imports. This is important for new projects because they now use theapplicationbuilder which emits full ESM code. Not using this option with certain third-party packages can result in build warnings and the potential for runtime failure. For existing applications that are considering migrating, information pertaining to this situation will be available within the documentation.Since the
allowSyntheticDefaultImportsis implied and automatically enabled whenesModuleInteropis enabled, the previous option has been replaced with this one.Reference: https://www.typescriptlang.org/tsconfig#esModuleInterop