Fix empty styles string and update component schematic to use single styles or styleUrl property
#26164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgp1130
added
action: cleanup
…ck JIT compilations Empty styles break the Webpack resource loader / PostCSS and generate an error. Fortunately there's no work to be done there, so we can just skip it and leave the empty string.
…le `style` or `styleUrl` property An array is no longer required in v17 and we always generate a single style or style URL anyways, so we may as well drop the array.
dgp1130
changed the title
style or styleUrl propertystyles string and update component schematic to use single styles or styleUrl property
alan-agius4
removed
the
action: cleanup
alan-agius4
approved these changes
Oct 28, 2023
alfaproject
reviewed
Oct 30, 2023
| @@ -236,6 +236,11 @@ function transformInlineStyleLiteral( | |||
| return node; | |||
| } | |||
|
|
|||
| // Don't transform empty strings as PostCSS will choke on them. No work to do anyways. | |||
| if (node.text === '') { | |||
There was a problem hiding this comment.
Should the input be trimmed first before the check?
There was a problem hiding this comment.
I believe this is only a problem if the file is completely empty, I think a file containing only whitespace should be ok.
There was a problem hiding this comment.
Yeah, I guess just an optimization to not even use style processing since there's no styles in that case. Probably not worth it anyway
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An array is no longer required in v17 and we always generate a single style or style URL anyways, so we may as well drop the array.
This actually revealed a bug in the Webpack compilation where an empty
styles: ''string would break PostCSS / the Webpack loader. Fixed this by just skipping resource inlining for an empty string, since there's no work to do anyways.