fix(@angular-devkit/build-angular): ensure secondary Angular compilations are unblocked on start errors #26225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions are unblocked on start errors When using the esbuild-based builders (`application`/`browser-esbuild`), the secondary Angular compilations will wait for the primary compilation to finish prior to bundling. This can potentially occur for polyfills that contain TypeScript files and the server code if enabled. However, if the Angular compilation throws an error during the start of the bundling process, the secondary compilations were never notified and instead would wait indefinitely. To avoid this situation, the compilations will now always be notified at the end of the compilation which will occur regardless. The build error that will be generated in these situations is currently not ideal and more verbose than needed but will provide information pertaining to the root cause.
alan-agius4
approved these changes
Nov 3, 2023
alan-agius4
added
target: rc
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the esbuild-based builders (
application/browser-esbuild), the secondary Angular compilations will wait for the primary compilation to finish prior to bundling. This can potentially occur for polyfills that contain TypeScript files and the server code if enabled. However, if the Angular compilation throws an error during the start of the bundling process, the secondary compilations were never notified and instead would wait indefinitely. To avoid this situation, the compilations will now always be notified at the end of the compilation which will occur regardless. The build error that will be generated in these situations is currently not ideal and more verbose than needed but will provide information pertaining to the root cause.Closes #26213