Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(@angular-devkit/build-angular): allow internal Angular compilation control of diagnostic modes #26861

Merged
merged 1 commit into from Jan 16, 2024

Conversation

clydin
Copy link
Member

@clydin clydin commented Jan 12, 2024

To support generate diagnostics in varying ways, the internal compilation classes now support a modes argument when diagnosing files during a build using the application builder. This is not exposed as an option at this time but can be experimented with a build using the NG_BUILD_TYPE_CHECK environment variable. This environment variable is not considered part of the public API and may be removed or altered in the future. Its current purpose is to allow profiling of the type checking diagnostics functionality of the build system.

…lation control of diagnostic modes

To support generate diagnostics in varying ways, the internal compilation classes
now support a `modes` argument when diagnosing files during a build using the `application` builder.
This is not exposed as an option at this time but can be experimented with a build using the
`NG_BUILD_TYPE_CHECK` environment variable. This environment variable is not considered part of the
public API and may be removed or altered in the future. Its current purpose is to allow profiling
of the type checking diagnostics functionality of the build system.
@clydin clydin added the target: minor This PR is targeted for the next minor release label Jan 12, 2024
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Jan 15, 2024
@clydin clydin merged commit 7d1cff0 into angular:main Jan 16, 2024
34 checks passed
@clydin clydin deleted the esbuild/control-diagnostics-internal branch January 16, 2024 13:21
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants