fix(@angular-devkit/build-angular): downgrade copy-webpack-plugin to workaround Node.js support issue #27092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…workaround Node.js support issue The `copy-webpack-plugin@12` package has a dependency on the `globby@14` package. The recently released `globby@14.0.1` uses the `merge-streams@2.1.0` package which requires a minimum Node.js version higher than the officially supported 18.13 for the Angular CLI. Due to both `globby` and `merge-streams` being transitive dependencies in end-user projects, the Angular CLI cannot directly control the package versions. However, `copy-webpack-plugin@11` uses `globby@13` which is not affected by the Node.js version problem. To workaround the Node.js compatibility problem, `copy-webpack-plugin` has been downgraded to version 11.0.0 which is the latest version in the 11 major for the package. The `copy-webpack-plugin` is only used with the Webpack-based builders when in watch mode. From a review of the commit history between 11.0.0 and 12.0.2 (latest at the time of this commit), it appears the only notable changes are several performance improvements and the major version update of `globby`. (cherry picked from commit e75aa9b)
clydin
added
the
action: review
alan-agius4
added
action: merge
alan-agius4
approved these changes
Feb 13, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
copy-webpack-plugin@12package has a dependency on theglobby@14package. The recently releasedglobby@14.0.1uses themerge-streams@2.1.0package which requires a minimum Node.js version higher than the officially supported 18.13 for the Angular CLI. Due to bothglobbyandmerge-streamsbeing transitive dependencies in end-user projects, the Angular CLI cannot directly control the package versions. However,copy-webpack-plugin@11usesglobby@13which is not affected by the Node.js version problem. To workaround the Node.js compatibility problem,copy-webpack-pluginhas been downgraded to version 11.0.0 which is the latest version in the 11 major for the package. Thecopy-webpack-pluginis only used with the Webpack-based builders when in watch mode. From a review of the commit history between 11.0.0 and 12.0.2 (latest at the time of this commit), it appears the only notable changes are several performance improvements and the major version update ofglobby.(cherry picked from commit e75aa9b)