refactor(@angular/build): send error status code on invalid external style component ID #28769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…style component ID If an invalid component identifier is provided to the development server for an external stylesheet requiring encapsulation, both a console message and a 400 status response will now be sent. This removes the potential for invalid styles to be sent to the browser.
clydin
added
the
action: review
…ackage in dev server Within the development server, the external stylesheet encapsulation logic has been adjusted to avoid needing to asynchronously import the `@angular/compiler` package within the request execution. This removes the need to pre-import the package at the start of the development server which was previously used to avoid a delay in stylesheet response on first use. The external stylesheet response execution is also now fully synchronous.
clydin
force-pushed
the
hmr/style-invalid-id-response
branch
from
4b22332 to
e0600e1
Compare
alan-agius4
approved these changes
Nov 1, 2024
clydin
added
action: merge
|
The changes were merged into the following branches: main, 19.0.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an invalid component identifier is provided to the development server for an external stylesheet requiring encapsulation, both a console message and a 400 status response will now be sent. This removes the potential for invalid styles to be sent to the browser.