Skip to content

Conversation

clydin
Copy link
Member

@clydin clydin commented Nov 1, 2024

A fix for Windows CI as well as improvements to prevent flakes.
The Windows E2E build and rebuild tests are also now added to PRs to reduce main CI failure occurrences.

The rebuild E2E test now waits for the development server to indicate it
has updated any clients before trying to fetch files. This improves the
reliability of the test when using the application builder.
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Nov 1, 2024
@clydin clydin force-pushed the windows-ci-fixes branch 2 times, most recently from 708a3a2 to a7d4c39 Compare November 2, 2024 00:37
When checking for bundler context invalidation for any referenced files,
the native path format is now used to ensure that the watch files can
be correctly matched. This is particularly important for Windows due to
the differing path segment separator.
@clydin clydin added the target: rc This PR is targeted for the next release-candidate label Nov 2, 2024
@clydin clydin marked this pull request as ready for review November 2, 2024 02:07
@clydin clydin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Nov 2, 2024
@clydin clydin requested a review from alan-agius4 November 2, 2024 02:24
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 2, 2024
@clydin clydin merged commit d16a9aa into angular:main Nov 2, 2024
36 checks passed
@clydin
Copy link
Member Author

clydin commented Nov 2, 2024

The changes were merged into the following branches: main, 19.0.x

@clydin clydin deleted the windows-ci-fixes branch November 2, 2024 19:58
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: @angular/build area: build & ci Related the build and CI infrastructure of the project target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants