feat(@angular-devkit/architect): require build schemas from modules

[realtimetodie]

PR Checklist

Please check to confirm your PR fulfills the following requirements:

• The commit message follows our guidelines: https://github.com/angular/angular-cli/blob/main/CONTRIBUTING.md#-commit-message-guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

What is the current behavior?

Currently, when you create a custom builder for Angular CLI, the builder schema can only be a reference to a local file in the manifest directory. This is cumbersome, for example when you want to reference an external schema from a module instead.

This is now working:

"schema": "./src/builders/browser-esbuild/schema.json"

This is not working:

"schema": "@angular-devkit/build-angular/src/builders/browser-esbuild/schema.json"

What is the new behavior?

It is now possible to require a builder schema from a module.

This is now working:

"schema": "./src/builders/browser-esbuild/schema.json"

and this too:

"schema": "@angular-devkit/build-angular/src/builders/browser-esbuild/schema.json"

Internal mechanics:

The localRequire.resolve function will look up the location of a module, but rather than loading the module, just return the resolved filename:

schemaPath = localRequire.resolve(schemaPath, {
  paths: [basePath],
});

If the module can not be found, a MODULE_NOT_FOUND error is thrown by Node.js and the filepath will be composed using the local manifest directory alternatively.

Error message:

In any case, the schema will be read using readFileSync and the error message will always be the same:

ENOENT: no such file or directory: <path>

Does this PR introduce a breaking change?

• Yes
• No

Other information

• Resolves local schema #11307

[realtimetodie]

@alan-agius4 I fixed the linting issue, please run the workflow again

[jkrems]

@realtimetodie It looks like the lint action now fails because of the commit message. Can you try amending the first commit with the lint fixes (e.g. using git rebase -i and fixup)?

[realtimetodie]

@jkrems done, sorry for the inconvenience

[clydin]

Can you squash the commits? Otherwise this looks good.

Thank you for the contribution.

[realtimetodie]

I squashed the commits. Thank your for taking the time to review my contribution.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}