fix(@angular-devkit/build-angular): jasmine.clock with app builder #29104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkrems
force-pushed
the
jk-jasmine-clock
branch
from
5e2836e to
ca8bd32
Compare
|
Somehow this broke existing behavior. Converting to draft for now while I investigate. |
jkrems
force-pushed
the
jk-jasmine-clock
branch
from
ca8bd32 to
33cfb81
Compare
|
I'm looking into removing the need for the |
jkrems
force-pushed
the
jk-jasmine-clock
branch
from
33cfb81 to
0aa10f6
Compare
jkrems
added
the
action: review
clydin
approved these changes
Dec 13, 2024
packages/angular_devkit/build_angular/src/builders/karma/application_builder.ts
Outdated
Show resolved
Hide resolved
jkrems
force-pushed
the
jk-jasmine-clock
branch
from
0aa10f6 to
fef09db
Compare
jkrems
added
action: merge
|
The changes were merged into the following branches: main, 19.0.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports the logic from WTR and webpack and adds a regression test for this behavior.
Fixes #28813