refactor(@angular/build): extract karma application builder into smaller modules #31186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ler modules The main `application_builder.ts` file was becoming too large and difficult to navigate. This change extracts several logical components into their own dedicated files: - Karma asset middleware - Karma polyfills plugin - Karma progress reporter - Code coverage utilities - Karma configuration helpers - General utility functions This improves the overall code structure, making it easier to understand, test, and maintain.
The main `initializeApplication` function within the Karma builder was overly large and handled several distinct responsibilities. This change refactors the function by breaking it down into three smaller, more focused functions: - `setupBuildOptions`: Gathers and configures the esbuild build options. - `runEsbuild`: Executes the esbuild build process. - `configureKarma`: Sets up the Karma configuration based on the build output. This decomposition improves the readability, testability, and maintainability of the Karma builder's application initialization process.
clydin
added
the
action: review
jkrems
approved these changes
Sep 11, 2025
clydin
added
action: merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main
application_builder.tsfile was becoming too large and difficult to navigate. This change extracts several logical components into their own dedicated files:This improves the overall code structure, making it easier to understand, test, and maintain.