Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text of initial tests must have sense #5501

Closed
wants to merge 2 commits into from
Closed

Text of initial tests must have sense #5501

wants to merge 2 commits into from

Conversation

vadim-shb
Copy link
Contributor

I'm not a native English speaker, so if I'm wrong - just reject this PR.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@vadim-shb
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

Then IDE highlights this directory as "Out of git".
Copy link
Contributor

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but this will be merged for the next minor version instead of a patch version, since it changes blueprints.

filipesilva pushed a commit that referenced this pull request May 8, 2017
Text of initial tests must have sense.

Close #5501
filipesilva pushed a commit that referenced this pull request May 8, 2017
Text of initial tests must have sense.

Close #5501
filipesilva pushed a commit that referenced this pull request May 8, 2017
Text of initial tests must have sense.

Close #5501
filipesilva pushed a commit that referenced this pull request May 8, 2017
Text of initial tests must have sense.

Close #5501
@hansl hansl closed this in 17ae140 May 9, 2017
filipesilva pushed a commit to filipesilva/angular-cli that referenced this pull request May 9, 2017
Text of initial tests must have sense.

Close angular#5501
dond2clouds pushed a commit to d2clouds/speedray-cli that referenced this pull request Apr 23, 2018
Text of initial tests must have sense.

Close angular#5501
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants