feat(@angular/cli): update tslint on updating prefix #5908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumitarora
force-pushed
the
fix-lint-issues
branch
2 times, most recently
from
8147d8e
to
63d0dd1
Compare
|
I think a flag on the set command to disable any secondary effects such as this would be useful. For example, someone might have a more complicated linting setup with cascading configs and wouldn't want the root config modified. |
Brocco
suggested changes
Apr 17, 2017
| const appConfig = getAppFromConfig(this.options.app); | ||
| if (options.prefix && appConfig.prefix && appConfig.prefix !== options.prefix) { | ||
| console.log(chalk.yellow(oneLine`You are using different prefix from app, | ||
| you might get lint errors. Please update "tslint.json" to remove those.`)); |
There was a problem hiding this comment.
Change this to read:
Please update "tslint.json" accordingly.
| const appConfig = getAppFromConfig(this.options.app); | ||
| if (options.prefix && appConfig.prefix && appConfig.prefix !== options.prefix) { | ||
| console.log(chalk.yellow(oneLine`You are using different prefix from app, | ||
| you might get lint errors. Please update "tslint.json" to remove those.`)); |
There was a problem hiding this comment.
Change this to read:
Please update "tslint.json" accordingly.
Brocco
approved these changes
Apr 17, 2017
dond2clouds
pushed a commit
to d2clouds/speedray-cli
that referenced
this pull request
Apr 23, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5794