fix(@angular/cli): simplify import path if possible #6184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cexbrayat
force-pushed
the
fix/simplify-imports
branch
from
1642923
to
8c57136
Compare
filipesilva
suggested changes
May 8, 2017
| @@ -229,7 +229,8 @@ export default Blueprint.extend({ | |||
| const className = stringUtils.classify(`${options.entity.name}Component`); | |||
| const fileName = stringUtils.dasherize(`${options.entity.name}.component`); | |||
| const componentDir = path.relative(path.dirname(this.pathToModule), this.generatePath); | |||
| const importPath = componentDir ? `./${componentDir}/${fileName}` : `./${fileName}`; | |||
| const normalizeRelativeDir = componentDir.startsWith('.') ? componentDir : `./${componentDir}`; | |||
| const importPath = componentDir ? `${normalizeRelativeDir}/${fileName}` : `./${fileName}`; | |||
There was a problem hiding this comment.
Can you instead use path.normalize on importPath? It guarantees the path is always simplified.
There was a problem hiding this comment.
Sadly path.normalize will simplify import {Hello} from './hello/hello' to import {Hello} from 'hello/hello', which breaks the app...
There was a problem hiding this comment.
Did not know that, you're right. Plus on windows it also replaces the slashes.
filipesilva
approved these changes
May 9, 2017
filipesilva
pushed a commit
to filipesilva/angular-cli
that referenced
this pull request
May 9, 2017
dond2clouds
pushed a commit
to d2clouds/speedray-cli
that referenced
this pull request
Apr 23, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6183