Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: import at least one locale-data with intl #6190

Merged
merged 1 commit into from
May 9, 2017
Merged

fix: import at least one locale-data with intl #6190

merged 1 commit into from
May 9, 2017

Conversation

maxisam
Copy link
Contributor

@maxisam maxisam commented May 5, 2017

It doesn't work if we just import intl.

Only put Intl here is a bit misleading. At least it got me :(

It doesn't work if we just import intl
Copy link
Contributor

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/andyearnshaw/Intl.js doesn't mention anything about having to import at least one locale. Can you open an issue describing the exact problem you're trying to solve here?

I think some browsers (like PhantomJS) require the locale but that's a very particular case.

@maxisam
Copy link
Contributor Author

maxisam commented May 8, 2017

It kinda does.

https://github.com/andyearnshaw/Intl.js/#getting-started

<script src="https://cdn.polyfill.io/v2/polyfill.min.js?features=Intl.~locale.en"></script>

https://github.com/andyearnshaw/Intl.js/#intljs-and-bower

Then include the polyfill in your pages as described below:

<script src="path/to/intl/Intl.js"></script> <script src="path/to/intl/locale-data/jsonp/en.js"></script>

there is no example showing you can use it without locale.en

And you can verify this by running a quick example on IE9 or any browser needs intl.js

@filipesilva
Copy link
Contributor

Oh I see it now, you're right! Thanks for fixing this.

@filipesilva filipesilva merged commit 1cc979f into angular:master May 9, 2017
@maxisam maxisam deleted the patch-1 branch May 9, 2017 17:34
filipesilva pushed a commit to filipesilva/angular-cli that referenced this pull request May 9, 2017
dond2clouds pushed a commit to d2clouds/speedray-cli that referenced this pull request Apr 23, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants