Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warning raised if targeting es2015 #7689

Closed
SanderElias opened this issue Sep 14, 2017 · 3 comments · Fixed by #7693
Closed

warning raised if targeting es2015 #7689

SanderElias opened this issue Sep 14, 2017 · 3 comments · Fixed by #7693
Assignees
Labels
P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful severity5: regression type: bug/fix

Comments

@SanderElias
Copy link

SanderElias commented Sep 14, 2017

Bug Report or Feature Request (mark with an x)

- [x ] bug report -> please search issues before submitting
- [ ] feature request

Versions.

@angular/cli: 1.5.0-beta.0
node: 8.5.0
os: linux x64
@angular/animations: 5.0.0-beta.7
@angular/common: 5.0.0-beta.7
@angular/compiler: 5.0.0-beta.7
@angular/core: 5.0.0-beta.7
@angular/forms: 5.0.0-beta.7
@angular/http: 5.0.0-beta.7
@angular/platform-browser: 5.0.0-beta.7
@angular/platform-browser-dynamic: 5.0.0-beta.7
@angular/router: 5.0.0-beta.7
@angular/cli: 1.5.0-beta.0
@angular/compiler-cli: 5.0.0-beta.7
@angular/language-service: 5.0.0-beta.7
typescript: 2.5.2

Repro steps.

ng new demo
update target in tsconfig.json to 'es2015'
ng build

The log given by the failure.

WARNING in ./node_modules/@angular/core/esm15/index.js
5132:15-36 Critical dependency: the request of a dependency is an expression
    at ImportLazyContextDependency.getWarnings (/home/sander/Documenten/test/demo/node_modules/webpack/lib/dependencies/ImportContextDependency.js:28:4)
    at Compilation.reportDependencyErrorsAndWarnings (/home/sander/Documenten/test/demo/node_modules/webpack/lib/Compilation.js:694:24)
    at Compilation.finish (/home/sander/Documenten/test/demo/node_modules/webpack/lib/Compilation.js:552:9)
    at applyPluginsParallel.err (/home/sander/Documenten/test/demo/node_modules/webpack/lib/Compiler.js:512:17)
    at /home/sander/Documenten/test/demo/node_modules/tapable/lib/Tapable.js:289:11
    at _addModuleChain (/home/sander/Documenten/test/demo/node_modules/webpack/lib/Compilation.js:498:11)
    at processModuleDependencies.err (/home/sander/Documenten/test/demo/node_modules/webpack/lib/Compilation.js:468:14)
    at _combinedTickCallback (internal/process/next_tick.js:131:7)
    at process._tickCallback (internal/process/next_tick.js:180:9)

Desired functionality.

clear the warning, it's pushing essential information out of the view!

@filipesilva filipesilva self-assigned this Sep 14, 2017
@filipesilva filipesilva added P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful package4: @angular-sdk/webpack type: bug/fix severity5: regression labels Sep 14, 2017
@filipesilva
Copy link
Contributor

This likely means that lazy routes are not working properly under es2015 with Angular version 5 as well.

@rtm
Copy link

rtm commented Jul 31, 2018

5132:15-36 Critical dependency: the request of a dependency is an expression

But I get this when targeting es5, and with no lazy routes involved.

What does it mean? What is the dependency involved here? What is the "request of a dependency"?

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful severity5: regression type: bug/fix
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants