Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(@angular-devkit/build-angular): render Sass using a pool of workers #20771

Merged
merged 1 commit into from
May 17, 2021

Conversation

clydin
Copy link
Member

@clydin clydin commented May 13, 2021

A pool of Workers is now used to process Sass render requests. This change allows multiple synchronous render operations to occur at the same time. Sass synchronous render operations can be up to two times faster than the asynchronous variant. The benefit will be most pronounced in applications with large amounts of Sass stylesheets.

Initial benchmarking with test projects containing large amounts of Sass stylesheets resulted in an additional ~15% total build time improvement over #20740

@clydin clydin added the target: patch This PR is targeted for the next patch release label May 13, 2021
@google-cla google-cla bot added the cla: yes label May 13, 2021
@clydin clydin requested a review from alan-agius4 May 13, 2021 17:52
A pool of Workers is now used to process Sass render requests. This change allows multiple synchronous render operations to occur at the same time. Sass synchronous render operations can be up to two times faster than the asynchronous variant. The benefit will be most pronounced in applications with large amounts of Sass stylesheets.
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label May 17, 2021
@alan-agius4 alan-agius4 merged commit 438c6d9 into angular:master May 17, 2021
@clydin clydin deleted the sass/worker-pool branch May 17, 2021 10:42
@clydin clydin mentioned this pull request May 17, 2021
1 task
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants