fix(@angular-devkit/build-angular): use istanbul-lib-instrument directly for karma code coverage #27857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clydin
force-pushed
the
karma/coverage-babel
branch
2 times, most recently
from
4e79544
to
623f782
Compare
eneajaho
reviewed
Jun 14, 2024
packages/angular_devkit/build_angular/src/builders/karma/tests/behavior/code-coverage_spec.ts
Outdated
Show resolved
Hide resolved
clydin
force-pushed
the
karma/coverage-babel
branch
2 times, most recently
from
992961b
to
f2774f2
Compare
…tly for karma code coverage The `istanbul-lib-instrument` package provides the required functionality needed to instrument code for test coverage within the context of the Angular CLI. Since the build pipeline already contains a customized babel preset, this package can be integrated directly into the pipeline. This reduces the number of dependencies required for `@angular-devkit/build-angular` including the deprecated `inflight` package.
clydin
force-pushed
the
karma/coverage-babel
branch
from
f2774f2
to
6c69854
Compare
clydin
added
the
action: review
alan-agius4
reviewed
Jun 17, 2024
packages/angular_devkit/build_angular/src/tools/babel/plugins/add-code-coverage.ts
Show resolved
Hide resolved
alan-agius4
added
action: cleanup
alan-agius4
approved these changes
Jun 17, 2024
alan-agius4
added
target: minor
|
@clydin, this does not apply cleanly on the patch branch. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
istanbul-lib-instrumentpackage provides the required functionality needed to instrument code for test coverage within the context of the Angular CLI. Since the build pipeline already contains a customized babel preset, this package can be integrated directly into the pipeline.This reduces the number of dependencies required for
@angular-devkit/build-angularincluding the deprecatedinflightpackage.