Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(new): production build is breaking angular child components #3167

Closed
wants to merge 2 commits into from

Conversation

MRHarrison
Copy link

Set keep_fnames: true fixes the issue.

Similar to the issues found here:
mishoo/UglifyJS#999
angular/angular#10618 (comment)

-Set keep_fnames: true fixes the issue.

Found the solutions here:
mishoo/UglifyJS#999
angular/angular#10618 (comment)
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot
Copy link

CLAs look good, thanks!

@MRHarrison MRHarrison changed the title Production Build is Breaking Angular Child Components from rendering fix(new): production build is breaking angular child components Nov 17, 2016
@filipesilva
Copy link
Contributor

According to angular/angular#10618 (comment) and #1937 this should not be a problem anymore since RC6.

Can you provide a repro where this problem is still manifest?

@filipesilva
Copy link
Contributor

Closed as inactive.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants