-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(build): add publicPath support via command and angular-cli.json #3285
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
c5a5523
to
beac9b3
Compare
What's the status of this? |
@filipesilva can this be included in next release? |
4eefd83
to
2ebdd7b
Compare
@filipesilva Could you please review this PR? Thx |
2ebdd7b
to
1e5882b
Compare
We also had to use a similar patch in our app, let's hope this gets merged ASAP |
0acd542
to
392caf0
Compare
any chance this could get merged? |
Where can I find the documentation about this ? Thx |
@halfonf |
@changLiuUNSW From which version is it enabled ? |
Not publish yet. You have to wait.... |
thx I hope it will be released soon :) |
Hi Chang I saw on stackoverflow that you automatized the cshtml edition. Thx a lot Found a solution thx anyway |
Saw that this new feature is released now. How is it actually used? |
@mmc41 I have the same scenario as you. I need to serve (and deploy) app as something like I just set it like this: |
@Meligy I am also using -bh but could only get it to work for ng build. If I try it with ng serve, I get an error that the option is not recognised. Thus I can serve the finished distribution under a "ui/" subpath but not when I am developing and just using "ng serve" |
Interesting. I believe I got it working with Maybe just setting the |
@mmc41 this PR is only for build, it does not add the functionality to When running So you'd normally just run |
Is there any documentation around this somewhere? Can I add this to be the default somewhere for |
The recommended way for such options as defaults is to create an npm script that calls the command with the options you need. So, in
And you call it like:
|
@changLiuUNSW Hello, your PR is very valuable as it solves the exact same issue I have. The only thing I also need to be able to do this in dev as well with |
@igormalyk |
…ngular#3285) Add publicPath option for webpack. User can specify publicPath via `--deploy-url` / `-d` from command line or add `deployUrl` to `angular-cli.json`. It can solve following issues: Change the public URL address of the output files (different from baseUrl). Manipulate the request url for chunk js files. It is very helpful to solve resources url and route lazying load issues for those applications which have different static files paths such as ASP.NET MVC. Fixes angular#3136 Fixes angular#2960 Fixes angular#2276 Fixes angular#2241 Fixes angular#3344
@igormalyk support for |
Hi there. Has this feature made it to a release yet? |
@Malabarba this has been released a long time ago. If you're experiencing problems with it please open an issue with reproduction steps for us to investigate. |
Sorry. I think I may have misunderstood the feature. So, I guess what I'm saying is sorry for the noise. 🙂 |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Add publicPath option for webpack.
User can specify publicPath via --deploy-url / -d from command line or add deployUrl to angular-cli.json
It can solve following issues:
It is very helpful to solve resources url and route lazying load issues for those applications which have different static files paths such as ASP.NET MVC.
This should fix
#3136
#2960
#2276
#2241
#3344