fix(@angular/cli): fix test typings #5504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipesilva
force-pushed
the
fix-test-typings
branch
from
4f05519
to
ad58c18
Compare
|
There seems to be something else going on here. |
filipesilva
force-pushed
the
fix-test-typings
branch
4 times, most recently
from
eb63b6f
to
5ab01b7
Compare
filipesilva
force-pushed
the
fix-test-typings
branch
4 times, most recently
from
31ece40
to
2d6d4e2
Compare
filipesilva
force-pushed
the
fix-test-typings
branch
3 times, most recently
from
1e72de0
to
055a4b7
Compare
Blocked by angular#5500 (fix is included in this PR so that CI will run). Our unit test webpack config was erroneously sending in entry points to karma-webpack, who should receive no entry points. This in turn was hiding errors related to typeRoots lookups. It was also causing unit tests compilation to behave weirdly: unit test errors would not stop compilation, because other entries would still compile. This might also have contributed to the overall slowness of unit tests in angular#5423. Related to TypeStrong/ts-node#283 Fix angular#3911 Fix angular#5332 Fix angular#5351
filipesilva
force-pushed
the
fix-test-typings
branch
3 times, most recently
from
79c68a8
to
fd29bfb
Compare
filipesilva
force-pushed
the
fix-test-typings
branch
from
fd29bfb
to
8ab3954
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(@angular/cli): fix test typings
Our unit test webpack config was erroneously sending in entry points to karma-webpack, who should receive no entry points.
This in turn was hiding errors related to typeRoots lookups.
It was also causing unit tests compilation to behave weirdly: unit test errors would not stop compilation, because other entries would still compile.
This might also have contributed to the overall slowness of unit tests in #5423.
Related to TypeStrong/ts-node#283
Fix #3911
Fix #5332
Fix #5351
fix(@angular/cli): fix error handling on test
Fix #2778
Fix #3424