feat(@angular/cli): improve unit test performance #6160

filipesilva · 2017-05-03T09:13:14Z

This PR uses a new Karma plugin to enable vendor bundles in unit tests,
increasing rebuild performance.

On a medium size project rebuilds times were 15x smaller (16.5s to 0.9s).

hccampos · 2017-05-03T17:19:45Z

Cool stuff! Any benchmarks you could share?

filipesilva · 2017-05-04T12:53:56Z

@hccampos I forgot to fill in the PR message with the commit message, it's updated now. TLDR 15x to 30x improvement, probably less for big projects.

cexbrayat · 2017-05-04T14:07:54Z

@filipesilva 👍 I just tried it, and it does start the test faster on rebuild. But to be honest, this does not completely fix #5423 (at least in my experiment): the progress report still go way slower on rebuild than on initial test:

Chrome 58.0.3029 (Mac OS X 10.12.4): Executed 102 of 102 SUCCESS (5.774 secs / 5.737 secs)
Chrome 58.0.3029 (Mac OS X 10.12.4): Executed 102 of 102 SUCCESS (28.755 secs / 28.73 secs)
Chrome 58.0.3029 (Mac OS X 10.12.4): Executed 102 of 102 SUCCESS (27.963 secs / 27.365 secs)

filipesilva · 2017-05-04T15:21:12Z

@cexbrayat bear in mind that we don't display how long building took, only how long karma took to run the tests. I haven't noticed delays while running the test though, so that's a relevant point.

Does this different in karma running time happen all the time, or only on some projects?

cexbrayat · 2017-05-04T15:28:05Z

@filipesilva Yes I know, I was just pointing out that (I think) #5423 has 2 parts. This PR solved the first one (rebuild took a long time, and it's now faster thanks to your PR 👍 ) but not the second part that @wardbell was pointing out: the progress report is ticking slower on rebuilds.
I'm witnessing this on pretty much all my projects.

filipesilva · 2017-05-04T19:52:22Z

@cexbrayat I wen't through a couple of rebuilds on my machine with both a brand new project and an existing medium sized project and couldn't notice any significant deviation on the reported karma re-test speeds (0.183/0.163/0.155 and 19.403/19.595/20.556).

In your case there's a whooping 500% difference though. Are you sure you're not experience chrome background throttling on your tests? I know chrome recently introduced that, and that it's been pretty bad for unit tests.

mgol · 2017-05-04T20:09:18Z

Good point @filipesilva. @cexbrayat make sure that during your testing the Chrome window is visible all the time, never covered by any other window.

If this was the problem, it will soon stop being an issue - in about a month Chrome 59 will be released with support for headless browsing and Karma already supports that. For now you'd have to be using Chrome Canary or beta.

cexbrayat · 2017-05-05T08:37:50Z

@filipesilva @mgol wasn't the background throttling disabled in Karma since a while ago? But you're right, it does indeed speed my tests if my browser is not on the background 🤔 So don't mind my comment, I may be experiencing a Chrome/Mac issue (possibly related to https://bugs.chromium.org/p/chromium/issues/detail?id=605498).

mgol · 2017-05-05T08:57:39Z

@cexbrayat Chrome has added a --disable-background-timer-throttling flag and karma-chrome-launcher uses it but, unfortunately, it doesn't fully unthrottle all the things.

The bug about that has been open for more than a year but, alas, nothing seems to be done on this front.

cexbrayat · 2017-05-05T09:01:46Z

@mgol I gave a try to the disable-renderer-backgrounding flag and it does appear to solve my issue. Thx you and @filipesilva for putting me on right track 👍

So I opened a bug on karma-chrome-launcher to have this flag included and offered a PR. Let's see how it goes.

Meanwhile, for those experimenting the same issue than me, you can switch your karma.conf.js to:

    customLaunchers: {
      chromeBackground: {
        base: 'Chrome',
        flags: ['--disable-renderer-backgrounding']
      }
    },
    browsers: ['chromeBackground'],

@filipesilva sorry for polluting this thread 🙏

filipesilva · 2017-05-05T09:09:29Z

@cexbrayat not at all, this is valuable info for people looking through this next time!

I wonder if we should add that renderer flag, but probably it's better to instead add a --headless flag for ng test/e2e when Chrome 59 comes out.

hansl

Love it, just 1 nit and a question.

hansl · 2017-05-05T15:46:39Z

packages/@angular/cli/blueprints/ng/files/karma.conf.js

@@ -15,25 +15,14 @@ module.exports = function (config) {
    client:{
      clearContext: false // leave Jasmine Spec Runner output visible in browser
    },
-    files: [


For projects using those, is this PR still working (even if it has the pre-PR performance hit)? Do we need to regenerate projects?

No need to regenerate projects. tests/e2e/tests/test/test-backwards-compat.ts tests that the old config works.

The new plugin has some logic that removes these entries if they are present in the karma config, that ensures backwards compatibility.

hansl · 2017-05-05T15:47:09Z

packages/@angular/cli/models/webpack-configs/test.ts

      }),
-      new KarmaWebpackEmitlessError()
-    ]
+      // new KarmaWebpackEmitlessError()


Forgotten comment.

This PR uses a new Karma plugin to enable vendor bundles in unit tests, increasing rebuild performance. On a medium size project rebuilds times were 15x smaller (16.5s to 0.9s). Fix angular#5423

cexbrayat · 2017-05-08T09:12:19Z

@filipesilva The PR I submitted to karma-chrome-launcher has been merged and a new version released: no need for us to tweak the karma.conf.js, we can only bump the version of the launcher.
I submitted a PR to do so (see #6216 )

filipesilva · 2017-05-08T09:21:26Z

@cexbrayat that's pretty cool, kudos!

angular#6160 broke `ng test` sourcemaps in Chrome, this PR fixes it. Before: ``` kamik@T460p MINGW64 D:/sandbox/master-project (master) $ ng test --sr 10% building modules 1/1 modules 0 active13 07 2017 16:38:43.942:INFO [karma]: Karma v1.7.0 server started at http://0.0.0.0:9876/ 13 07 2017 16:38:43.945:INFO [launcher]: Launching browser Chrome with unlimited concurrency 13 07 2017 16:38:43.953:INFO [launcher]: Starting browser Chrome 13 07 2017 16:38:54.099:INFO [Chrome 59.0. 3071 (Windows 10 0.0.0)]: Connected on socket Xdep72ofT_Q7MWBHAAAA with id 76010950 Chrome 59.0.3071 (Windows 10 0.0.0) AppComponent should have as title 'app' FAILED Expected 'app' to equal 'forced bug'. at Object.<anonymous> (http://localhost:9876/_karma_webpack_/main.bundle.js:89:27) at ZoneDelegate.webpackJsonp.../../../../../../../sandbox/master-project/node_modules/zone.js/dist/zone.js.ZoneDelegate.invoke (http://localhost:9 876/_karma_webpack_/polyfills.bundle.js:2704:26) at AsyncTestZoneSpec.webpackJsonp.../../../../../../../sandbox/master-project/node_modules/zone.js/dist/async-test.js.AsyncTestZoneSpec.onInvoke ( http://localhost:9876/_karma_webpack_/vendor.bundle.js:55972:39) at ProxyZoneSpec.webpackJsonp.../../../../../../../sandbox/master-project/node_modules/zone.js/dist/proxy.js.ProxyZoneSpec.onInvoke (http://localh ost:9876/_karma_webpack_/vendor.bundle.js:56735:39) Chrome 59.0.3071 (Windows 10 0.0.0): Executed 2 of 3 (1 FAILED) (0 secs / 0.162 secs) Chrome 59.0.3071 (Windows 10 0.0.0) AppComponent should have as title 'app' FAILED Expected 'app' to equal 'forced bug'. at Object.<anonymous> (http://localhost:9876/_karma_webpack_/main.bundle.js:89:27) at ZoneDelegate.webpackJsonp.../../../../../../../sandbox/master-project/node_modules/zone.js/dist/zone.js.ZoneDelegate.invoke (http://localhost:9 876/_karma_webpack_/polyfills.bundle.js:2704:26) at AsyncTestZoneSpec.webpackJsonp.../../../../../../../sandbox/master-project/node_modules/zone.js/dist/async-test.js.AsyncTestZoneSpec.onInvoke ( http://localhost:9876/_karma_webpack_/vendor.bundle.js:55972:39) at ProxyZoneSpec.webpackJsonp.../../../../../../../sandbox/master-project/node_modules/zone.js/dist/proxy.js.ProxyZoneSpec.onInvoke (http://localh Chrome 59.0.3071 (Windows 10 0.0.0): Executed 3 of 3 (1 FAILED) (0.225 secs / 0.204 secs) ``` After: ``` kamik@T460p MINGW64 D:/sandbox/master-project (master) $ ng test --sr 10% building modules 1/1 modules 0 active13 07 2017 16:37:59.478:INFO [karma]: Karma v1.7.0 server started at http://0.0.0.0:9876/ 13 07 2017 16:37:59.481:INFO [launcher]: Launching browser Chrome with unlimited concurrency 13 07 2017 16:37:59.487:INFO [launcher]: Starting browser Chrome 13 07 2017 16:38:08.559:INFO [Chrome 59.0. 3071 (Windows 10 0.0.0)]: Connected on socket ixHN4NzVFTEW1iYiAAAA with id 92819713 Chrome 59.0.3071 (Windows 10 0.0.0) AppComponent should have as title 'app' FAILED Expected 'app' to equal 'forced bug'. at Object.<anonymous> D:/sandbox/master-project/src/app/app.component.spec.ts:23:23) at ZoneDelegate.webpackJsonp.../../../../../../../sandbox/master-project/node_modules/zone.js/dist/zone.js.ZoneDelegate.invoke D:/sandbox/master-p roject/node_modules/zone.js/dist/zone.js:391:1) at AsyncTestZoneSpec.webpackJsonp.../../../../../../../sandbox/master-project/node_modules/zone.js/dist/async-test.js.AsyncTestZoneSpec.onInvoke D :/sandbox/master-project/node_modules/zone.js/dist/async-test.js:49:1) at ProxyZoneSpec.webpackJsonp.../../../../../../../sandbox/master-project/node_modules/zone.js/dist/proxy.js.ProxyZoneSpec.onInvoke D:/sandbox/mas ter-project/node_modules/zone.js/dist/proxy.js:76:1) Chrome 59.0.3071 (Windows 10 0.0.0): Executed 2 of 3 (1 FAILED) (0 secs / 0.367 secs) Chrome 59.0.3071 (Windows 10 0.0.0) AppComponent should have as title 'app' FAILED Expected 'app' to equal 'forced bug'. at Object.<anonymous> D:/sandbox/master-project/src/app/app.component.spec.ts:23:23) at ZoneDelegate.webpackJsonp.../../../../../../../sandbox/master-project/node_modules/zone.js/dist/zone.js.ZoneDelegate.invoke D:/sandbox/master-p roject/node_modules/zone.js/dist/zone.js:391:1) at AsyncTestZoneSpec.webpackJsonp.../../../../../../../sandbox/master-project/node_modules/zone.js/dist/async-test.js.AsyncTestZoneSpec.onInvoke D :/sandbox/master-project/node_modules/zone.js/dist/async-test.js:49:1) at ProxyZoneSpec.webpackJsonp.../../../../../../../sandbox/master-project/node_modules/zone.js/dist/proxy.js.ProxyZoneSpec.onInvoke D:/sandbox/mas Chrome 59.0.3071 (Windows 10 0.0.0): Executed 3 of 3 (1 FAILED) (0.421 secs / 0.4 secs) ``` Fix angular#6583

#6160 broke `ng test` sourcemaps in Chrome, this PR fixes it. Before: ``` kamik@T460p MINGW64 D:/sandbox/master-project (master) $ ng test --sr 10% building modules 1/1 modules 0 active13 07 2017 16:38:43.942:INFO [karma]: Karma v1.7.0 server started at http://0.0.0.0:9876/ 13 07 2017 16:38:43.945:INFO [launcher]: Launching browser Chrome with unlimited concurrency 13 07 2017 16:38:43.953:INFO [launcher]: Starting browser Chrome 13 07 2017 16:38:54.099:INFO [Chrome 59.0. 3071 (Windows 10 0.0.0)]: Connected on socket Xdep72ofT_Q7MWBHAAAA with id 76010950 Chrome 59.0.3071 (Windows 10 0.0.0) AppComponent should have as title 'app' FAILED Expected 'app' to equal 'forced bug'. at Object.<anonymous> (http://localhost:9876/_karma_webpack_/main.bundle.js:89:27) at ZoneDelegate.webpackJsonp.../../../../../../../sandbox/master-project/node_modules/zone.js/dist/zone.js.ZoneDelegate.invoke (http://localhost:9 876/_karma_webpack_/polyfills.bundle.js:2704:26) at AsyncTestZoneSpec.webpackJsonp.../../../../../../../sandbox/master-project/node_modules/zone.js/dist/async-test.js.AsyncTestZoneSpec.onInvoke ( http://localhost:9876/_karma_webpack_/vendor.bundle.js:55972:39) at ProxyZoneSpec.webpackJsonp.../../../../../../../sandbox/master-project/node_modules/zone.js/dist/proxy.js.ProxyZoneSpec.onInvoke (http://localh ost:9876/_karma_webpack_/vendor.bundle.js:56735:39) Chrome 59.0.3071 (Windows 10 0.0.0): Executed 2 of 3 (1 FAILED) (0 secs / 0.162 secs) Chrome 59.0.3071 (Windows 10 0.0.0) AppComponent should have as title 'app' FAILED Expected 'app' to equal 'forced bug'. at Object.<anonymous> (http://localhost:9876/_karma_webpack_/main.bundle.js:89:27) at ZoneDelegate.webpackJsonp.../../../../../../../sandbox/master-project/node_modules/zone.js/dist/zone.js.ZoneDelegate.invoke (http://localhost:9 876/_karma_webpack_/polyfills.bundle.js:2704:26) at AsyncTestZoneSpec.webpackJsonp.../../../../../../../sandbox/master-project/node_modules/zone.js/dist/async-test.js.AsyncTestZoneSpec.onInvoke ( http://localhost:9876/_karma_webpack_/vendor.bundle.js:55972:39) at ProxyZoneSpec.webpackJsonp.../../../../../../../sandbox/master-project/node_modules/zone.js/dist/proxy.js.ProxyZoneSpec.onInvoke (http://localh Chrome 59.0.3071 (Windows 10 0.0.0): Executed 3 of 3 (1 FAILED) (0.225 secs / 0.204 secs) ``` After: ``` kamik@T460p MINGW64 D:/sandbox/master-project (master) $ ng test --sr 10% building modules 1/1 modules 0 active13 07 2017 16:37:59.478:INFO [karma]: Karma v1.7.0 server started at http://0.0.0.0:9876/ 13 07 2017 16:37:59.481:INFO [launcher]: Launching browser Chrome with unlimited concurrency 13 07 2017 16:37:59.487:INFO [launcher]: Starting browser Chrome 13 07 2017 16:38:08.559:INFO [Chrome 59.0. 3071 (Windows 10 0.0.0)]: Connected on socket ixHN4NzVFTEW1iYiAAAA with id 92819713 Chrome 59.0.3071 (Windows 10 0.0.0) AppComponent should have as title 'app' FAILED Expected 'app' to equal 'forced bug'. at Object.<anonymous> D:/sandbox/master-project/src/app/app.component.spec.ts:23:23) at ZoneDelegate.webpackJsonp.../../../../../../../sandbox/master-project/node_modules/zone.js/dist/zone.js.ZoneDelegate.invoke D:/sandbox/master-p roject/node_modules/zone.js/dist/zone.js:391:1) at AsyncTestZoneSpec.webpackJsonp.../../../../../../../sandbox/master-project/node_modules/zone.js/dist/async-test.js.AsyncTestZoneSpec.onInvoke D :/sandbox/master-project/node_modules/zone.js/dist/async-test.js:49:1) at ProxyZoneSpec.webpackJsonp.../../../../../../../sandbox/master-project/node_modules/zone.js/dist/proxy.js.ProxyZoneSpec.onInvoke D:/sandbox/mas ter-project/node_modules/zone.js/dist/proxy.js:76:1) Chrome 59.0.3071 (Windows 10 0.0.0): Executed 2 of 3 (1 FAILED) (0 secs / 0.367 secs) Chrome 59.0.3071 (Windows 10 0.0.0) AppComponent should have as title 'app' FAILED Expected 'app' to equal 'forced bug'. at Object.<anonymous> D:/sandbox/master-project/src/app/app.component.spec.ts:23:23) at ZoneDelegate.webpackJsonp.../../../../../../../sandbox/master-project/node_modules/zone.js/dist/zone.js.ZoneDelegate.invoke D:/sandbox/master-p roject/node_modules/zone.js/dist/zone.js:391:1) at AsyncTestZoneSpec.webpackJsonp.../../../../../../../sandbox/master-project/node_modules/zone.js/dist/async-test.js.AsyncTestZoneSpec.onInvoke D :/sandbox/master-project/node_modules/zone.js/dist/async-test.js:49:1) at ProxyZoneSpec.webpackJsonp.../../../../../../../sandbox/master-project/node_modules/zone.js/dist/proxy.js.ProxyZoneSpec.onInvoke D:/sandbox/mas Chrome 59.0.3071 (Windows 10 0.0.0): Executed 3 of 3 (1 FAILED) (0.421 secs / 0.4 secs) ``` Fix #6583

angular#6160 broke `ng test` sourcemaps in Chrome, this PR fixes it. Before: ``` kamik@T460p MINGW64 D:/sandbox/master-project (master) $ ng test --sr 10% building modules 1/1 modules 0 active13 07 2017 16:38:43.942:INFO [karma]: Karma v1.7.0 server started at http://0.0.0.0:9876/ 13 07 2017 16:38:43.945:INFO [launcher]: Launching browser Chrome with unlimited concurrency 13 07 2017 16:38:43.953:INFO [launcher]: Starting browser Chrome 13 07 2017 16:38:54.099:INFO [Chrome 59.0. 3071 (Windows 10 0.0.0)]: Connected on socket Xdep72ofT_Q7MWBHAAAA with id 76010950 Chrome 59.0.3071 (Windows 10 0.0.0) AppComponent should have as title 'app' FAILED Expected 'app' to equal 'forced bug'. at Object.<anonymous> (http://localhost:9876/_karma_webpack_/main.bundle.js:89:27) at ZoneDelegate.webpackJsonp.../../../../../../../sandbox/master-project/node_modules/zone.js/dist/zone.js.ZoneDelegate.invoke (http://localhost:9 876/_karma_webpack_/polyfills.bundle.js:2704:26) at AsyncTestZoneSpec.webpackJsonp.../../../../../../../sandbox/master-project/node_modules/zone.js/dist/async-test.js.AsyncTestZoneSpec.onInvoke ( http://localhost:9876/_karma_webpack_/vendor.bundle.js:55972:39) at ProxyZoneSpec.webpackJsonp.../../../../../../../sandbox/master-project/node_modules/zone.js/dist/proxy.js.ProxyZoneSpec.onInvoke (http://localh ost:9876/_karma_webpack_/vendor.bundle.js:56735:39) Chrome 59.0.3071 (Windows 10 0.0.0): Executed 2 of 3 (1 FAILED) (0 secs / 0.162 secs) Chrome 59.0.3071 (Windows 10 0.0.0) AppComponent should have as title 'app' FAILED Expected 'app' to equal 'forced bug'. at Object.<anonymous> (http://localhost:9876/_karma_webpack_/main.bundle.js:89:27) at ZoneDelegate.webpackJsonp.../../../../../../../sandbox/master-project/node_modules/zone.js/dist/zone.js.ZoneDelegate.invoke (http://localhost:9 876/_karma_webpack_/polyfills.bundle.js:2704:26) at AsyncTestZoneSpec.webpackJsonp.../../../../../../../sandbox/master-project/node_modules/zone.js/dist/async-test.js.AsyncTestZoneSpec.onInvoke ( http://localhost:9876/_karma_webpack_/vendor.bundle.js:55972:39) at ProxyZoneSpec.webpackJsonp.../../../../../../../sandbox/master-project/node_modules/zone.js/dist/proxy.js.ProxyZoneSpec.onInvoke (http://localh Chrome 59.0.3071 (Windows 10 0.0.0): Executed 3 of 3 (1 FAILED) (0.225 secs / 0.204 secs) ``` After: ``` kamik@T460p MINGW64 D:/sandbox/master-project (master) $ ng test --sr 10% building modules 1/1 modules 0 active13 07 2017 16:37:59.478:INFO [karma]: Karma v1.7.0 server started at http://0.0.0.0:9876/ 13 07 2017 16:37:59.481:INFO [launcher]: Launching browser Chrome with unlimited concurrency 13 07 2017 16:37:59.487:INFO [launcher]: Starting browser Chrome 13 07 2017 16:38:08.559:INFO [Chrome 59.0. 3071 (Windows 10 0.0.0)]: Connected on socket ixHN4NzVFTEW1iYiAAAA with id 92819713 Chrome 59.0.3071 (Windows 10 0.0.0) AppComponent should have as title 'app' FAILED Expected 'app' to equal 'forced bug'. at Object.<anonymous> D:/sandbox/master-project/src/app/app.component.spec.ts:23:23) at ZoneDelegate.webpackJsonp.../../../../../../../sandbox/master-project/node_modules/zone.js/dist/zone.js.ZoneDelegate.invoke D:/sandbox/master-p roject/node_modules/zone.js/dist/zone.js:391:1) at AsyncTestZoneSpec.webpackJsonp.../../../../../../../sandbox/master-project/node_modules/zone.js/dist/async-test.js.AsyncTestZoneSpec.onInvoke D :/sandbox/master-project/node_modules/zone.js/dist/async-test.js:49:1) at ProxyZoneSpec.webpackJsonp.../../../../../../../sandbox/master-project/node_modules/zone.js/dist/proxy.js.ProxyZoneSpec.onInvoke D:/sandbox/mas ter-project/node_modules/zone.js/dist/proxy.js:76:1) Chrome 59.0.3071 (Windows 10 0.0.0): Executed 2 of 3 (1 FAILED) (0 secs / 0.367 secs) Chrome 59.0.3071 (Windows 10 0.0.0) AppComponent should have as title 'app' FAILED Expected 'app' to equal 'forced bug'. at Object.<anonymous> D:/sandbox/master-project/src/app/app.component.spec.ts:23:23) at ZoneDelegate.webpackJsonp.../../../../../../../sandbox/master-project/node_modules/zone.js/dist/zone.js.ZoneDelegate.invoke D:/sandbox/master-p roject/node_modules/zone.js/dist/zone.js:391:1) at AsyncTestZoneSpec.webpackJsonp.../../../../../../../sandbox/master-project/node_modules/zone.js/dist/async-test.js.AsyncTestZoneSpec.onInvoke D :/sandbox/master-project/node_modules/zone.js/dist/async-test.js:49:1) at ProxyZoneSpec.webpackJsonp.../../../../../../../sandbox/master-project/node_modules/zone.js/dist/proxy.js.ProxyZoneSpec.onInvoke D:/sandbox/mas Chrome 59.0.3071 (Windows 10 0.0.0): Executed 3 of 3 (1 FAILED) (0.421 secs / 0.4 secs) ``` Fix angular#6583

angular-automatic-lock-bot · 2019-09-12T00:41:56Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

filipesilva added the state: WIP label May 3, 2017

googlebot added the cla: yes label May 3, 2017

filipesilva force-pushed the test-perf branch from 8440e37 to f967a4e Compare May 3, 2017 10:02

filipesilva removed the state: WIP label May 3, 2017

filipesilva requested review from sumitarora, hansl and Brocco May 3, 2017 10:09

filipesilva force-pushed the test-perf branch from f967a4e to b6cba57 Compare May 3, 2017 10:10

filipesilva mentioned this pull request May 4, 2017

It takes forever in "92% chunk asset optimization" can it be cached or disabled? #5775

Closed

filipesilva mentioned this pull request May 4, 2017

ng test not reporting TypeScript errors #5863

Closed

filipesilva force-pushed the test-perf branch from b6cba57 to 2eec7d6 Compare May 4, 2017 19:49

filipesilva mentioned this pull request May 5, 2017

Support having multiple entries codymikol/karma-webpack#165

Closed

sumitarora previously approved these changes May 5, 2017

View reviewed changes

hansl previously approved these changes May 5, 2017

View reviewed changes

feat(@angular/cli): improve ng test performance

083fc11

This PR uses a new Karma plugin to enable vendor bundles in unit tests, increasing rebuild performance. On a medium size project rebuilds times were 15x smaller (16.5s to 0.9s). Fix angular#5423

filipesilva dismissed stale reviews from hansl and sumitarora via 083fc11 May 5, 2017 20:07

filipesilva force-pushed the test-perf branch from 2eec7d6 to 083fc11 Compare May 5, 2017 20:07

cexbrayat mentioned this pull request May 8, 2017

chore(@angular/cli): bump karma-chrome-launcher #6216

Merged

filipesilva mentioned this pull request May 8, 2017

feat(@angular/cli): add jasmine html report when using code coverage flag #5514

Closed

filipesilva assigned hansl May 8, 2017

hansl approved these changes May 8, 2017

View reviewed changes

filipesilva merged commit 1cd0a08 into angular:master May 8, 2017

filipesilva deleted the test-perf branch May 8, 2017 15:51

This was referenced May 12, 2017

fix(@angular/cli): added mime to deps to fix broken test command from… #6296

Closed

The ng test command results in Executed 0 of 0 ERROR on a new project #6284

Closed

This was referenced May 23, 2017

"ng test" - no code coverage report if --code-coverage and --reporters options used together #5685

Closed

Jasmine HTML report not displayed when code coverage enabled during test #5136

Closed

filipesilva mentioned this pull request Jul 13, 2017

Feature request: functions/URLs as file sources karma-runner/karma#2774

Open

filipesilva mentioned this pull request Jul 13, 2017

fix(@angular/cli): fix ng test report sourcemaps #6968

Merged

filipesilva mentioned this pull request Aug 24, 2017

Ability to Disable chunk optimization for ng test command #7363

Closed

filipesilva mentioned this pull request Oct 20, 2017

Not working sourcemap + karma #7987

Closed

filipesilva mentioned this pull request Nov 22, 2017

Total rebuild test time in medium and large projects #8579

Closed

angular-automatic-lock-bot bot unassigned hansl Sep 12, 2019

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(@angular/cli): improve unit test performance #6160

feat(@angular/cli): improve unit test performance #6160

filipesilva commented May 3, 2017 •

edited

Loading

hccampos commented May 3, 2017

filipesilva commented May 4, 2017

cexbrayat commented May 4, 2017

filipesilva commented May 4, 2017

cexbrayat commented May 4, 2017

filipesilva commented May 4, 2017

mgol commented May 4, 2017

cexbrayat commented May 5, 2017

mgol commented May 5, 2017

cexbrayat commented May 5, 2017

filipesilva commented May 5, 2017

hansl left a comment

hansl May 5, 2017

filipesilva May 5, 2017 •

edited

Loading

hansl May 5, 2017

filipesilva May 5, 2017

cexbrayat commented May 8, 2017

filipesilva commented May 8, 2017

angular-automatic-lock-bot bot commented Sep 12, 2019

feat(@angular/cli): improve unit test performance #6160

feat(@angular/cli): improve unit test performance #6160

Conversation

filipesilva commented May 3, 2017 • edited Loading

hccampos commented May 3, 2017

filipesilva commented May 4, 2017

cexbrayat commented May 4, 2017

filipesilva commented May 4, 2017

cexbrayat commented May 4, 2017

filipesilva commented May 4, 2017

mgol commented May 4, 2017

cexbrayat commented May 5, 2017

mgol commented May 5, 2017

cexbrayat commented May 5, 2017

filipesilva commented May 5, 2017

hansl left a comment

Choose a reason for hiding this comment

hansl May 5, 2017

Choose a reason for hiding this comment

filipesilva May 5, 2017 • edited Loading

Choose a reason for hiding this comment

hansl May 5, 2017

Choose a reason for hiding this comment

filipesilva May 5, 2017

Choose a reason for hiding this comment

cexbrayat commented May 8, 2017

filipesilva commented May 8, 2017

angular-automatic-lock-bot bot commented Sep 12, 2019

filipesilva commented May 3, 2017 •

edited

Loading

filipesilva May 5, 2017 •

edited

Loading