Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(@angular/cli): enable full node module resolution for project deps #6276

Merged
merged 1 commit into from May 15, 2017
Merged

fix(@angular/cli): enable full node module resolution for project deps #6276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/@angular/cli/models/webpack-configs/common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ export function getCommonConfig(wco: WebpackConfigOptions) {
devtool: buildOptions.sourcemaps ? 'source-map' : false,
resolve: {
extensions: ['.ts', '.js'],
modules: [nodeModules],
modules: ['node_modules', nodeModules],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the difference between modules: ['node_modules', nodeModules], and just modules: ['node_modules']?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It provides a fallback to the project's node modules. Useful for linked modules with peer dependencies. When such a package is installed normally the peer dependencies would normally be located in the project's node modules.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get it now, it's for when the linked library does not contain the peerDep but the app does. 👍

},
resolveLoader: {
modules: [nodeModules]
Expand Down
13 changes: 13 additions & 0 deletions tests/e2e/tests/misc/module-resolution.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
import { appendToFile, prependToFile } from '../../utils/fs';
import { ng, silentNpm } from '../../utils/process';


export default async function () {
await silentNpm('install', 'firebase@3.7.8');

await prependToFile('src/app/app.module.ts', 'import * as firebase from \'firebase\';');
await appendToFile('src/app/app.module.ts', 'firebase.initializeApp({});');

await ng('build');
await ng('build', '--aot');
}