refactor(build): migrate navigation component translation to git patch #1085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove adev-ja navigation.component.html and .en.html files - Add translate-navigation.patch to tools/adev-patches/ - Update tools/update-origin.ts to exclude navigation from localized files - Navigation translations now handled via patch system for better maintainability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
ナビゲーションコンポーネントの翻訳をファイルベースからgitパッチシステムに移行しました。
ファイル全体に対して翻訳箇所が少ないため、パッチによる差分管理のほうが把握しやすくなります。
変更内容
adev-ja/src/app/core/layout/navigation/navigation.component.htmlおよび.en.htmlファイルを削除tools/adev-patches/translate-navigation.patchを新規作成tools/update-origin.tsからナビゲーションファイルをローカライズ対象から除外テスト
pnpm testでパッチの適用が正常に動作することを確認済みチェックリスト