Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

tutorial test fails - test.sh calls testacular instead of karma #47

Closed
b1alpha opened this issue May 6, 2013 · 5 comments
Closed

tutorial test fails - test.sh calls testacular instead of karma #47

b1alpha opened this issue May 6, 2013 · 5 comments

Comments

@b1alpha
Copy link

b1alpha commented May 6, 2013

Summary: When you try to run test.sh or test.bat you get an error because this line was not changed to call karma and there is no step to add an alias in the tutorial. Just breaks.
Steps to reproduce, call /scripts/test.sh
Expected result: it launches karma
Acutal result: it launches nothing and calls the wrong program

Suggested fix: please update this file - https://github.com/angular/angular-phonecat/blame/master/scripts/test.sh

@b1alpha
Copy link
Author

b1alpha commented May 7, 2013

http://grab.by/mkac
https://github.com/angular/angular-phonecat/blame/master/scripts/test.bat

all the references in the project should be looked up and changed you cant call testacular anymore so this fails

@IgorMinar
Copy link
Contributor

this has been resolved in the master branch. please reclone the repo or run ./scripts/update-repo.sh

@adityamenon
Copy link

Wow! I did not know that shifting around branches can somehow also adjust tags in Git? What sorcery is this! Thank you! Even doing git checkout -f step-9 etc., works with karma being used instead of testacular.

@IgorMinar
Copy link
Contributor

I just rebased and retagged the repo. No magic. Just git.

On Tue, May 21, 2013 at 11:19 AM, aditya menon notifications@github.comwrote:

Wow! I did not know that shifting around branches can somehow also adjust
tags in Git? What sorcery is this! Thank you! Even doing git checkout -f
step-9 etc., works with karma being used instead of testacular.


Reply to this email directly or view it on GitHubhttps://github.com//issues/47#issuecomment-18226882
.

@adityamenon
Copy link

May I humbly ask for your thoughts on #53 as well? I was going to make the same suggestion on Angular seed...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants