This repository was archived by the owner on Dec 4, 2017. It is now read-only.
docs(style-guide): make each style clickable for easier referencing #1339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @KyleMcNutt. Our commits are very similar. One thing mine does different (which I prefer) is that I moved the anchor to the name of the rule (i.e. "Rule of One") That way when the page loads, it shows the rule name at the top, then the rule number below it. I find the name very useful. |
|
@olore I can see that perspective, I was going for the minimal change just to make it more obvious what can be linked to. It looks like from discussion in the other issues that an on-hover icon seems to be the preferred approach, but I'll leave that to the Angular teams designers to decide. |
|
@wardbell I am OK with this.. Are you? |
|
Thanks. Merged as ce05f9b |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make it easier to capture the link to a specific style so that it can be shared.