Skip to content
This repository was archived by the owner on Dec 4, 2017. It is now read-only.

Conversation

mattezell
Copy link
Contributor

"...builds a tree of ActivatedRoutes,..." should be "...builds a tree of ActivatedRoutes,..."

"...builds a tree of `ActivatedRoute`s,..." should be "...builds a tree of `ActivatedRoutes`,..."
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@mattezell
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@kwalrath
Copy link
Contributor

kwalrath commented Aug 5, 2016

We don't want to imply that the type name is ActivatedRoutes, so this change won't work, as is.

But you're right that "ActivatedRoutes" is not great.

How about "ActivatedRoute objects"?

@wardbell
Copy link
Contributor

wardbell commented Aug 6, 2016

@kwalrath Exactly! I'll fix it as I merge it

@wardbell wardbell closed this in 2817467 Aug 6, 2016
@mattezell
Copy link
Contributor Author

Ha! Thanks, @kwalrath - you're right... I completely overlooked that before hitting submit :) 'ActiveRoute' not 'ActiveRoutes'.. Rookie mistake. Glad it got sorted.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants