Skip to content
This repository was archived by the owner on Dec 4, 2017. It is now read-only.

Conversation

bignimbus
Copy link

Addresses: #2231

And also a small issue where an <h1> tag is being included in a template where it was previously deleted.

At https://angular.io/docs/ts/latest/tutorial/toh-pt5.html:

Near the top, user sees:

screen shot 2016-09-02 at 6 08 15 pm

Since the user has moved the <h1> tag to another template, we should not see it here, below:

screen shot 2016-09-02 at 6 07 37 pm

Thanks in advance for your consideration of these tweaks.

- add short blurb explaining HeroService#create
- include HeroService#create snippet
- earlier in tutorial we moved the h1 tag out of heroes.component.ts
- create new example
- update example reference in jade template
@Foxandxss
Copy link
Member

Looks good to me, but that is a big new file just for the template.

@bignimbus
Copy link
Author

Makes sense, I can cut that down to just the essentials.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

wardbell added a commit to IdeaBlade/angular.io that referenced this pull request Sep 3, 2016
fixes angular#2231
also addresses `<h1>` issue raised in PR angular#2256
@wardbell
Copy link
Contributor

wardbell commented Sep 3, 2016

Thanks for taking this on. I appreciate the effort and your care.

I don't think we should add an entire file just to delete the <h1> . The maintenance burden is not worth it. You can see the problems already. For example, your version still has the title property which shouldn't be there. And all those irrelevant #docregion tags.

I think the world will survive an extra <h1>, especially if we tell folks to delete it.

Your other change to ToH-6 is important.

I incorporated these thoughts into #2264. Closing yours. Thanks.

@wardbell wardbell closed this Sep 3, 2016
wardbell added a commit that referenced this pull request Sep 3, 2016
fixes #2231
also addresses `<h1>` issue raised in PR #2256
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants