This repository was archived by the owner on Dec 4, 2017. It is now read-only.
green = do #2257
Merged
green = do #2257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blue = consider red = avoid light gray = why
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
blue = consider
red = avoid
light gray = why
Addressing the point raised here ... #1958
Docs team discussed and agree that Green is best for Do, and Red for avoid. We'll keep the neutral blue for consider.
we decided not to use shades of colors as some folks (like me) have difficulty discerning shades.
cc @wardbell @Foxandxss